-
Notifications
You must be signed in to change notification settings - Fork 37
Open
Labels
needs-kindIndicates an issue or PR lacks a `kind/foo` label and requires one.Indicates an issue or PR lacks a `kind/foo` label and requires one.needs-priorityIndicates an issue or PR lacks a `priority/foo` label and requires one.Indicates an issue or PR lacks a `priority/foo` label and requires one.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Description
Problem
The TaskReaper.Run() method in reaper/task.go has a SQL query that excludes Pending and Running states from selection, but the subsequent switch statement still contains handlers for these states. This means the TTL logic for Pending and Running tasks will never execute.
Current Query
The query currently filters for:
state IN ? and released = ?With states: Created, Succeeded, Failed, Canceled
Missing States
The query should also include:
task.Pendingtask.Running
Impact
Tasks in Pending or Running states will not be reaped according to their TTL settings, potentially leading to resource accumulation.
Related
- PR: ✨ Better pod retention / Perf-scale. #897
- Comment: ✨ Better pod retention / Perf-scale. #897 (comment)
- Reported by: @coderabbitai
Metadata
Metadata
Assignees
Labels
needs-kindIndicates an issue or PR lacks a `kind/foo` label and requires one.Indicates an issue or PR lacks a `kind/foo` label and requires one.needs-priorityIndicates an issue or PR lacks a `priority/foo` label and requires one.Indicates an issue or PR lacks a `priority/foo` label and requires one.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Type
Projects
Status
🏗 In progress