Fix GORM column names and slice accumulation in Dependency cycle check

[coderabbitai]

Bug Description

In migration/v19/model/application.go, the Dependency.BeforeCreate() method has two issues in its cycle detection logic:

1. Incorrect GORM Column Name

The query uses struct field name "ToID" instead of the expected database column name "to_id". This causes the query to silently miss rows and fail to detect cycles properly.

2. Slice Accumulation Bug

The nextDeps slice is never reset between iterations, causing stale/duplicated results to accumulate across loop iterations.

Location

• File: migration/v19/model/application.go
• Method: Dependency.BeforeCreate() (lines ~93-111)

Fix Required

1. Change query to use DB column name: db.Where("to_id IN ?", nextAppsIDs).Find(&nextDeps)
2. Reset slice each iteration: nextDeps = nextDeps[:0] before the query

References

• Identified in PR: ✨ Identity associated to application by role. #911
• Comment: ✨ Identity associated to application by role. #911 (comment)
• Requested by: @jortel

[konveyor-ci-bot]

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.