Skip to content

Conversation

@take-cheeze
Copy link
Contributor

No description provided.

@ksss
Copy link
Owner

ksss commented Jan 24, 2025

@take-cheeze Thank you for PR.
I have been away from mruby related development.
Could you please share some background on this issue?

@take-cheeze
Copy link
Contributor Author

I don't know the background also but seems it's removed in this commit: mruby/mruby@89d83c2

@ksss
Copy link
Owner

ksss commented Jan 24, 2025

@take-cheeze Thank you for your help.

I tried removing the dependency on mruby-print, and it seems to work fine on CI.
If you don't see any issues, how about removing the dependency on mruby-print in this PR?

@take-cheeze
Copy link
Contributor Author

#16 seems to be fine. Thank you for your support!

@take-cheeze take-cheeze deleted the print-if-exist branch January 24, 2025 03:23
@ksss
Copy link
Owner

ksss commented Jan 24, 2025

OK, Thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants