Skip to content

Commit 5567117

Browse files
authored
Merge pull request #120 from launchdarkly/2.7.2
Prepare 2.7.2 release
2 parents 8e9b460 + 23429f9 commit 5567117

File tree

5 files changed

+10
-4
lines changed

5 files changed

+10
-4
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
All notable changes to the LaunchDarkly client-side JavaScript SDK will be documented in this file.
44
This project adheres to [Semantic Versioning](http://semver.org).
55

6+
## [2.7.2] - 2018-10-17
7+
### Fixed:
8+
- Disconnecting from the stream does not close the browser tab anymore.
9+
(Thanks, [Sawtaytoes](https://github.com/launchdarkly/js-client/issues/119).)
10+
- The configuration property `evaluationReasons` was misnamed as `evaluationExplanations` in the TypeScript definitions.
11+
612
## [2.7.1] - 2018-09-27
713
### Fixed:
814
- Event posts did not include the HTTP header that specifies the SDK version. They now do again. Note that the `sendLDHeaders` option does not affect this; if the header is turned off for flag requests, it should still be sent in events, since events always require a CORS preflight check anyway (and are delivered asynchronously, so the OPTIONS request does not slow down page loads).

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ldclient-js",
3-
"version": "2.7.1",
3+
"version": "2.7.2",
44
"description": "LaunchDarkly SDK for JavaScript",
55
"author": "LaunchDarkly <[email protected]>",
66
"license": "Apache-2.0",

src/Stream.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export default function Stream(baseUrl, environment, hash, config) {
2020
stream.disconnect = function() {
2121
clearTimeout(reconnectTimeoutReference);
2222
reconnectTimeoutReference = null;
23-
close();
23+
closeConnection();
2424
};
2525

2626
stream.isConnected = function() {

typings.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ declare module 'ldclient-js' {
131131
* variationDetail() method. Since this increases the size of network requests,
132132
* such information is not sent unless you request it with this option.
133133
*/
134-
evaluationExplanations?: boolean;
134+
evaluationReasons?: boolean;
135135

136136
/**
137137
* True (the default) if the client should make a request to LaunchDarkly for

0 commit comments

Comments
 (0)