Skip to content

Commit 51fc585

Browse files
authored
chore: Correct reusable workflow usage for publishing docs. (#203)
## Summary Needed to call the re-usable workflows as jobs, not as steps. ## How did you test this change? <!-- Frontend - Leave a screencast or a screenshot to visually describe the changes. --> ## Are there any deployment considerations? <!-- Backend - Do we need to consider migrations or backfilling data? -->
1 parent 0341b0f commit 51fc585

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

.github/workflows/release-please.yml

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,13 @@ jobs:
4747
aws-role-arn: ${{ vars.AWS_ROLE_ARN }}
4848

4949
release-python-docs:
50-
runs-on: ubuntu-latest
50+
needs: ['release-package', 'release-python-plugin']
51+
if: ${{ needs.release-package.outputs.python-plugin-released == 'true' }}
5152
permissions:
5253
contents: write
53-
needs: ['release-python-plugin']
54-
steps:
55-
- name: Build and Publish Docs
56-
uses: launchdarkly/observability-sdk/.github/workflows/manual-publish-docs.yml@main
57-
with:
58-
workspace_path: sdk/@launchdarkly/observability-python
54+
uses: launchdarkly/observability-sdk/.github/workflows/manual-publish-docs.yml@main
55+
with:
56+
workspace_path: sdk/@launchdarkly/observability-python
5957

6058
release-python-provenance:
6159
needs: ['release-package', 'release-python-plugin']
@@ -108,16 +106,13 @@ jobs:
108106
dry-run: false
109107

110108
release-dotnet-plugin-docs:
111-
runs-on: ubuntu-latest
109+
needs: ['release-package', 'release-dotnet-plugin']
112110
permissions:
113111
contents: write
114-
needs: ['release-package', 'release-dotnet-plugin']
115112
if: ${{ needs.release-package.outputs.dotnet-plugin-released == 'true' }}
116-
steps:
117-
- name: Build and Publish Docs
118-
uses: launchdarkly/observability-sdk/.github/workflows/manual-publish-docs.yml@main
119-
with:
120-
workspace_path: sdk/@launchdarkly/observability-dotnet
113+
uses: launchdarkly/observability-sdk/.github/workflows/manual-publish-docs.yml@main
114+
with:
115+
workspace_path: sdk/@launchdarkly/observability-dotnet
121116

122117
release-dotnet-sdk-provenance:
123118
needs: ['release-package', 'release-dotnet-plugin']

0 commit comments

Comments
 (0)