Commit eec90b9
authored
add pg option to turn off attributes (#32)
## Summary
Updates the `@highlight-run/node` SDK per customer request.
Allow customers to control `pg` instrumentation via new setting.
Fix express.js middleware handler incorrectly representing the end of an
API request.
Update dependency definition to correctly reference option types from
`highlight.run`
## How did you test this change?
spans showing correct duration
<img width="1518" alt="Screenshot 2025-05-14 at 00 39 24"
src="https://github.com/user-attachments/assets/f6261ffd-dd6a-4f10-b2e5-a8475f341ae0"
/>
<img width="1319" alt="Screenshot 2025-05-14 at 00 39 48"
src="https://github.com/user-attachments/assets/504a413e-8f07-4f6e-8692-ec1456eb0599"
/>
<img width="441" alt="Screenshot 2025-05-14 at 00 55 41"
src="https://github.com/user-attachments/assets/1c45e65a-6196-4048-9dff-428ee05e0791"
/>
with the `disablePgInstrumentationAttributes` setting off
<img width="1347" alt="Screenshot 2025-05-14 at 00 57 23"
src="https://github.com/user-attachments/assets/b875e191-660e-451f-84ba-b5ad4cc63a5f"
/>
## Are there any deployment considerations?
<!--
Backend - Do we need to consider migrations or backfilling data?
-->
## Does this work require review from our design team?
<!--
Request review from julian-highlight / our design team
-->1 parent 55b0538 commit eec90b9
File tree
16 files changed
+398
-316
lines changed- e2e/nextjs/src
- app/api/app-router-test
- sdk
- highlight-apollo
- highlight-hono
- highlight-nest
- highlight-next
- highlight-node
- src
- highlight-remix
16 files changed
+398
-316
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| 18 | + | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
0 commit comments