From 8d30961183856deda3f6d8067b6d3c361a9b4035 Mon Sep 17 00:00:00 2001
From: ccschmitz <christopher.schmitz@launchdarkly.com>
Date: Mon, 29 Sep 2025 11:24:12 -0500
Subject: [PATCH] Add addSessionProperties to RecordSDK

---
 e2e/react-router/src/routes/root.tsx          | 36 ++++++++++++++
 .../record-add-session-properties.test.ts     | 49 +++++++++++++++++++
 sdk/highlight-run/src/api/record.ts           |  5 ++
 sdk/highlight-run/src/sdk/LDRecord.ts         |  4 ++
 sdk/highlight-run/src/sdk/record.ts           |  8 +++
 5 files changed, 102 insertions(+)
 create mode 100644 sdk/highlight-run/src/__tests__/record-add-session-properties.test.ts

diff --git a/e2e/react-router/src/routes/root.tsx b/e2e/react-router/src/routes/root.tsx
index e5a16b527..751142950 100644
--- a/e2e/react-router/src/routes/root.tsx
+++ b/e2e/react-router/src/routes/root.tsx
@@ -301,6 +301,42 @@ export default function Root() {
 			>
 				LDObserve.stop()
 			</button>
+			<div
+				style={{
+					marginTop: 8,
+					padding: 12,
+					border: '1px solid #ddd',
+					borderRadius: 6,
+					maxWidth: 720,
+				}}
+			>
+				<h3>Session Properties</h3>
+				<p>
+					Add custom session-level attributes via{' '}
+					<code>LDRecord.addSessionProperties</code>.
+				</p>
+				<textarea
+					style={{
+						width: '100%',
+						minHeight: 120,
+						fontFamily: 'monospace',
+					}}
+					defaultValue='{"plan":"pro","favoriteColor":"seafoam"}'
+					placeholder='{"key":"value"}'
+				/>
+				<div style={{ display: 'flex', gap: 8, marginTop: 8 }}>
+					<button
+						onClick={() => {
+							const value =
+								document.querySelector('textarea')?.value ?? ''
+
+							LDRecord.addSessionProperties(JSON.parse(value))
+						}}
+					>
+						Apply session properties
+					</button>
+				</div>
+			</div>
 		</div>
 	)
 }
diff --git a/sdk/highlight-run/src/__tests__/record-add-session-properties.test.ts b/sdk/highlight-run/src/__tests__/record-add-session-properties.test.ts
new file mode 100644
index 000000000..2e5887b6f
--- /dev/null
+++ b/sdk/highlight-run/src/__tests__/record-add-session-properties.test.ts
@@ -0,0 +1,49 @@
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+vi.mock('../client/workers/highlight-client-worker?worker&inline', () => {
+	class FakeWorker {
+		onmessage = (_e: any) => {}
+		postMessage = vi.fn((_message: any) => null)
+	}
+	return { default: FakeWorker }
+})
+
+import { RecordSDK } from '../sdk/record'
+import { LDRecord } from '../sdk/LDRecord'
+import { MessageType } from '../client/workers/types'
+
+describe('Record addSessionProperties', () => {
+	let recordImpl: RecordSDK
+
+	beforeEach(() => {
+		recordImpl = new RecordSDK({
+			organizationID: '1',
+			environment: 'test',
+			sessionSecureID: 'test-session',
+		})
+	})
+
+	it('posts Properties message with session type to the worker', () => {
+		const postSpy = vi.spyOn((recordImpl as any)._worker, 'postMessage')
+
+		const props = { plan: 'pro', count: 1, active: true }
+		recordImpl.addSessionProperties(props)
+
+		expect(postSpy).toHaveBeenCalled()
+		const call = postSpy.mock.calls[0]?.[0] as any
+		expect(call?.message?.type).toBe(MessageType.Properties)
+		expect(call?.message?.propertyType).toEqual({ type: 'session' })
+		expect(call?.message?.propertiesObject).toMatchObject(props)
+	})
+
+	it('LDRecord proxies addSessionProperties to implementation', () => {
+		// Load the implementation into the LDRecord buffered proxy
+		LDRecord.load(recordImpl)
+
+		const spy = vi.spyOn(recordImpl, 'addSessionProperties')
+		const props = { foo: 'bar' }
+		LDRecord.addSessionProperties(props)
+
+		expect(spy).toHaveBeenCalledWith(props)
+	})
+})
diff --git a/sdk/highlight-run/src/api/record.ts b/sdk/highlight-run/src/api/record.ts
index 023fa1503..247dceb2a 100644
--- a/sdk/highlight-run/src/api/record.ts
+++ b/sdk/highlight-run/src/api/record.ts
@@ -14,6 +14,11 @@ export interface Record {
 	 * Stop the session recording.
 	 */
 	stop: () => void
+	/**
+	 * Add custom session-level properties. These are attached to the current session
+	 * and are searchable, but do not create timeline Track events.
+	 */
+	addSessionProperties: (properties: { [key: string]: any }) => void
 	/**
 	 * Snapshot an HTML <canvas> element in WebGL manual snapshotting mode.
 	 * See {@link https://www.highlight.io/docs/getting-started/browser/replay-configuration/canvas#manual-snapshotting}
diff --git a/sdk/highlight-run/src/sdk/LDRecord.ts b/sdk/highlight-run/src/sdk/LDRecord.ts
index 96a15d63e..742d41a1b 100644
--- a/sdk/highlight-run/src/sdk/LDRecord.ts
+++ b/sdk/highlight-run/src/sdk/LDRecord.ts
@@ -20,6 +20,10 @@ class _LDRecord extends BufferedClass<Record> implements Record {
 		return this._sdk.stop()
 	}
 
+	addSessionProperties(properties: { [key: string]: any }) {
+		return this._bufferCall('addSessionProperties', [properties])
+	}
+
 	getRecordingState() {
 		return this._isLoaded
 			? this._bufferCall('getRecordingState', [])
diff --git a/sdk/highlight-run/src/sdk/record.ts b/sdk/highlight-run/src/sdk/record.ts
index 83d4c7309..c8bf7f071 100644
--- a/sdk/highlight-run/src/sdk/record.ts
+++ b/sdk/highlight-run/src/sdk/record.ts
@@ -403,6 +403,14 @@ export class RecordSDK implements Record {
 		})
 	}
 
+	/**
+	 * Add custom session-level properties. These are attached to the current session
+	 * and are searchable, but do not create timeline Track events.
+	 */
+	addSessionProperties(properties: { [key: string]: any }) {
+		this.addProperties(properties, { type: 'session' })
+	}
+
 	async start(options?: StartOptions) {
 		if (
 			navigator?.userAgent?.includes('Googlebot') ||