From 28c883cebba0e618733499008f94102ca6d0a894 Mon Sep 17 00:00:00 2001 From: Vadim Korolik Date: Wed, 1 Oct 2025 18:09:25 -0500 Subject: [PATCH 1/2] fix: support recordError with nullish Error --- sdk/highlight-run/src/sdk/observe.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sdk/highlight-run/src/sdk/observe.ts b/sdk/highlight-run/src/sdk/observe.ts index 0f6011b33..199a3fad0 100644 --- a/sdk/highlight-run/src/sdk/observe.ts +++ b/sdk/highlight-run/src/sdk/observe.ts @@ -254,6 +254,9 @@ export class ObserveSDK implements Observe { source?: string, type?: ErrorMessageType, ) { + if (!error) { + error = new Error(message ?? 'Unknown error') + } if (error instanceof Error && error.cause) { payload = { ...payload, From d63bee4e6523a4b6117ac36263e8e8016e5b9e31 Mon Sep 17 00:00:00 2001 From: Vadim Korolik Date: Wed, 1 Oct 2025 18:16:35 -0500 Subject: [PATCH 2/2] simplify --- sdk/highlight-run/src/sdk/observe.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sdk/highlight-run/src/sdk/observe.ts b/sdk/highlight-run/src/sdk/observe.ts index 199a3fad0..11ba9d29e 100644 --- a/sdk/highlight-run/src/sdk/observe.ts +++ b/sdk/highlight-run/src/sdk/observe.ts @@ -254,9 +254,7 @@ export class ObserveSDK implements Observe { source?: string, type?: ErrorMessageType, ) { - if (!error) { - error = new Error(message ?? 'Unknown error') - } + error = error || new Error('Unknown error') if (error instanceof Error && error.cause) { payload = { ...payload,