fix: Fix generation of tags capability tests (#290)

Author: keelerm84

sdktests/common_tests_instance_id.go

@@ -42,13 +42,13 @@ func (c CommonInstanceIDTests) Run(t *ldtest.T) {
 		verifyRequestHeader(t, dataSource.Endpoint())
 	})
 
-	t.Run("poll requests", func(t *ldtest.T) {
-		t.Capabilities().HasAny(servicedef.CapabilityServerSidePolling, servicedef.CapabilityClientSide)
-
-		dataSource := NewSDKDataSource(t, nil, DataSourceOptionPolling())
-		_ = NewSDKClient(t, c.baseSDKConfigurationPlus(dataSource)...)
-		verifyRequestHeader(t, dataSource.Endpoint())
-	})
+	if t.Capabilities().HasAny(servicedef.CapabilityClientSide, servicedef.CapabilityServerSidePolling) {
+		t.Run("poll requests", func(t *ldtest.T) {
+			dataSource := NewSDKDataSource(t, nil, DataSourceOptionPolling())
+			_ = NewSDKClient(t, c.baseSDKConfigurationPlus(dataSource)...)
+			verifyRequestHeader(t, dataSource.Endpoint())
+		})
+	}
 
 	t.Run("event posts", func(t *ldtest.T) {
 		dataSource := NewSDKDataSource(t, nil)

sdktests/common_tests_tags.go

@@ -72,21 +72,20 @@ func (c CommonTagsTests) Run(t *ldtest.T) {
 		}
 	})
 
-	t.Run("poll requests", func(t *ldtest.T) {
-		// Currently server-side SDK test services do not support polling
-		t.RequireCapability(servicedef.CapabilityClientSide)
-
-		for _, p := range c.makeValidTagsTestParams() {
-			t.Run(p.description, func(t *ldtest.T) {
-				tags := p.tags
-				dataSource := NewSDKDataSource(t, nil, DataSourceOptionPolling())
-				_ = NewSDKClient(t, c.baseSDKConfigurationPlus(
-					withTagsConfig(tags),
-					dataSource)...)
-				verifyRequestHeader(t, p, dataSource.Endpoint())
-			})
-		}
-	})
+	if t.Capabilities().HasAny(servicedef.CapabilityClientSide, servicedef.CapabilityServerSidePolling) {
+		t.Run("poll requests", func(t *ldtest.T) {
+			for _, p := range c.makeValidTagsTestParams() {
+				t.Run(p.description, func(t *ldtest.T) {
+					tags := p.tags
+					dataSource := NewSDKDataSource(t, nil, DataSourceOptionPolling())
+					_ = NewSDKClient(t, c.baseSDKConfigurationPlus(
+						withTagsConfig(tags),
+						dataSource)...)
+					verifyRequestHeader(t, p, dataSource.Endpoint())
+				})
+			}
+		})
+	}
 
 	t.Run("event posts", func(t *ldtest.T) {
 		dataSource := NewSDKDataSource(t, nil)
@@ -207,10 +206,20 @@ func (c CommonTagsTests) makeValidTagsTestParams() []tagsTestParams {
 		o.None[string](),
 		o.Some(""), // empty string
 	}
-	for i := 0; i < len(allAllowedTagChars); i += maxTagValueLength {
-		j := h.IfElse(i > len(allAllowedTagChars), len(allAllowedTagChars), i)
-		values = append(values, o.Some(allAllowedTagChars[i:j]))
+
+	// Generate test to use all valid characters
+	batchSize := min(maxTagValueLength, len(allAllowedTagChars))
+	for i := 0; i < len(allAllowedTagChars)-batchSize; i += batchSize {
+		if i+batchSize > len(allAllowedTagChars) {
+			values = append(values, o.Some(allAllowedTagChars[i:]))
+		} else {
+			values = append(values, o.Some(allAllowedTagChars[i:i+batchSize]))
+		}
 	}
+
+	// Ensure we test the maximum length
+	values = append(values, o.Some(strings.Repeat(allAllowedTagChars[1:2], maxTagValueLength)))
+
 	for _, appID := range values {
 		for _, appVersion := range values {
 			tags := servicedef.SDKConfigTagsParams{ApplicationID: appID, ApplicationVersion: appVersion}

sdktests/constants.go

@@ -1,10 +1,7 @@
 package sdktests
 
 const (
-	// Application tags sent to the cloud are not allowed to have spaces.  However, the SDKs
-	// are sanitizing input, so spaces are allowed in the input.  That is why this set
-	// of characters includes a space.
-	allAllowedTagChars = " ._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
+	allAllowedTagChars = "._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
 	tagNameAppID       = "application-id"
 	tagNameAppVersion  = "application-version"
 )