Refactor backend

Author: leonvogt

src/browser_panel/messaging.js

@@ -22,7 +22,7 @@ export const handleBackendToPanelMessage = (message, port) => {
       setTurboCables(message.turboCables, message.url)
       setPort(port)
       break
-    case BACKEND_TO_PANEL_MESSAGES.SET_STIMULUS_CONTROLLERS:
+    case BACKEND_TO_PANEL_MESSAGES.SET_STIMULUS_DATA:
       setStimulusData(message.stimulusData, message.url)
       setPort(port)
       break

src/browser_panel/page/backend.js

@@ -95,36 +95,14 @@ function init() {
       }
     }
 
-    // TurboFrameObserver delegate methods
-    frameConnected(frame) {
+    // Delegate methods
+    turboFramesChanged() {
       this.sendTurboFrames()
     }
-    frameDisconnected(frame) {
-      this.sendTurboFrames()
-    }
-    frameAttributeChanged(frame, attributeName, oldValue, newValue) {
-      this.sendTurboFrames()
-    }
-
-    // TurboCableObserver delegate methods
-    turboCableConnected(element) {
-      this.sendTurboCableData()
-    }
-    turboCableDisconnected(element) {
+    turboCableChaned() {
       this.sendTurboCableData()
     }
-    turboCableAttributeChanged(element, attributeName, oldValue, newValue) {
-      this.sendTurboCableData()
-    }
-
-    // Stimulus delegate methods
-    stimulusControllerConnected(element) {
-      this.sendStimulusData()
-    }
-    stimulusControllerDisonnected(element) {
-      this.sendStimulusData()
-    }
-    stimulusControllerChanged(element, attributeName, oldValue, newValue) {
+    stimulusDataChanged() {
       this.sendStimulusData()
     }
 
@@ -190,7 +168,7 @@ function init() {
       this._postMessage({
         stimulusData: this.observers.stimulus.getStimulusData(),
         url: btoa(window.location.href),
-        type: BACKEND_TO_PANEL_MESSAGES.SET_STIMULUS_CONTROLLERS,
+        type: BACKEND_TO_PANEL_MESSAGES.SET_STIMULUS_DATA,
       })
     }, 10)
 

src/browser_panel/page/stimulus_observer.js

@@ -33,15 +33,15 @@ export default class StimulusObserver {
       const controllerData = this.buildStimulusElementData(element, identifier)
       this.controllerElements.get(uuid).push(controllerData)
     })
-    this.delegate.stimulusControllerConnected(element)
+    this.delegate.stimulusDataChanged()
   }
 
   elementUnmatched(element) {
     const uuid = getUUIDFromElement(element)
 
     if (this.controllerElements.has(uuid)) {
       this.controllerElements.delete(uuid)
-      this.delegate.stimulusControllerDisonnected(element)
+      this.delegate.stimulusDataChanged()
     }
   }
 
@@ -50,12 +50,11 @@ export default class StimulusObserver {
     if (this.matchElement(element)) {
       const uuid = getUUIDFromElement(element)
       if (this.controllerElements.has(uuid)) {
-        const newValue = element.getAttribute(attributeName)
         const newControllerElementData = this.controllerElements.get(uuid).map((controllerData) => {
           return this.buildStimulusElementData(element, controllerData.identifier)
         })
         this.controllerElements.set(uuid, newControllerElementData)
-        this.delegate.stimulusControllerChanged(element, attributeName, oldValue, newValue)
+        this.delegate.stimulusDataChanged()
       }
     }
   }

src/browser_panel/page/turbo_cable_observer.js

@@ -24,7 +24,7 @@ export default class TurboCableObserver {
     if (!this.streamSources.has(uuid)) {
       const turboCableData = this.buildTurboCableData(element)
       this.streamSources.set(uuid, turboCableData)
-      this.delegate.turboCableConnected(element)
+      this.delegate.turboCableChaned()
     }
   }
 
@@ -33,7 +33,7 @@ export default class TurboCableObserver {
 
     if (this.streamSources.has(uuid)) {
       this.streamSources.delete(uuid)
-      this.delegate.turboCableDisconnected(element)
+      this.delegate.turboCableChaned()
     }
   }
 
@@ -51,7 +51,7 @@ export default class TurboCableObserver {
         }
         turboCableData.connected = element.hasAttribute("connected")
 
-        this.delegate.turboCableAttributeChanged(element, attributeName, oldValue, newValue)
+        this.delegate.turboCableChaned()
       }
     }
   }

src/browser_panel/page/turbo_frame_observer.js

@@ -22,7 +22,7 @@ export default class TurboFrameObserver {
     if (!this.frames.has(uuid)) {
       const frameData = this.buildFrameData(element)
       this.frames.set(uuid, frameData)
-      this.delegate.frameConnected(element)
+      this.delegate.turboFramesChanged()
     }
   }
 
@@ -31,7 +31,7 @@ export default class TurboFrameObserver {
 
     if (this.frames.has(uuid)) {
       this.frames.delete(uuid)
-      this.delegate.frameDisconnected(element)
+      this.delegate.turboFramesChanged()
     }
   }
 
@@ -50,7 +50,7 @@ export default class TurboFrameObserver {
 
         frameData.serializedTag = stringifyHTMLElementTag(element)
 
-        this.delegate.frameAttributeChanged(element, attributeName, oldValue, newValue)
+        this.delegate.turboFramesChanged()
       }
     }
   }

src/lib/constants.js

@@ -10,7 +10,7 @@ export const PORT_IDENTIFIERS = {
 export const BACKEND_TO_PANEL_MESSAGES = {
   SET_TURBO_FRAMES: "set-turbo-frames",
   SET_TURBO_CABLES: "set-turbo-cables",
-  SET_STIMULUS_CONTROLLERS: "set-stimulus-controllers",
+  SET_STIMULUS_DATA: "set-stimulus-data",
   TURBO_STREAM_RECEIVED: "turbo-stream-received",
   TURBO_EVENT_RECEIVED: "turbo-event-received",
   HEALTH_CHECK_RESPONSE: "health-check-response",