fix!: Set content type if error occurs in Leptos middleware #4216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- When a server function return an error, the content type header is not set. Solution -------- Use the `FromServerFnError::Encoder::CONTENT_TYPE` associated constant to set the content type header on the returned API response. Note: A similar issue occurs if an error is [returned in Leptos's middleware chain](https://github.com/leptos-rs/leptos/blob/b986fe11dc63a803d026f9ccae804e880c2a702b/server_fn/src/middleware/mod.rs#L77). However, I believe resolving that will require adding a field to the `BoxedService`, which would be an API-breaking change.
Problem ------- If an error occurs [in Leptos's middleware chain](https://github.com/leptos-rs/leptos/blob/main/server_fn/src/middleware/mod.rs#L77), the content-type header of the returned error response is not set. Solution -------- Save the error's content-type from the boxed service in `BoxedService`, and pass the content type into `Service::run`. Note that this requires the following breaking changes: - Add a new field to `BoxedService`. - Update the `Service::run` trait method to accept the error's content type as a parameter. However, since this requires breaking changes anyway, this PR achieves the following in a more extensible way (but still API-breaking): - Replace the `ser` field in `BoxedService` with a `ServiceRunConfig` that contains the `ser` error serializer and the error's content type string. - Mark `BoxedService` as `#[non_exhaustive]` so new fields can be added in the future without breaking the API. - Replace the `ser` parameter of `Service::run` with the `ServiceRunConfig` This allows `Service::run` to remain the same even if new fields are added to the `ServiceRunConfig` in the future.
4 tasks
spencewenski
changed the title
benwis
requested changes
Aug 7, 2025
Contributor
benwis
left a comment
benwis
left a comment
There was a problem hiding this comment.
As mentioned in the other PR, let's refactor this to edit error_response()
Contributor
Author
|
This is fixed by #4215 now since it was decided in that PR that it should be resolved in an API-breaking way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If an error occurs
in Leptos's middleware chain, the content-type header of the returned error response is not set.
Solution
Save the error's content-type from the boxed service in
BoxedService, and pass the content type intoService::run.Note that this requires the following breaking changes:
BoxedService.Service::runtrait method to accept the error's content type as a parameter.However, since this requires breaking changes anyway, this PR achieves
the following in a more extensible way (but still API-breaking):
serfield inBoxedServicewith aServiceRunConfigthat contains thesererror serializer and the error's content type string.BoxedServiceas#[non_exhaustive]so new fields can be added in the future without breaking the API.serparameter ofService::runwith theServiceRunConfigThis allowsService::runto remain the same even if new fields are added to theServiceRunConfigin the future.Note: this is written on top of another PR that's currently open, so there are some changes in this PR that are originally from that PR.
Closes #4209