Skip to content

Commit 3be8ac3

Browse files
committed
mirror: Always disable unused CLI arguments warning for feature probe
In commit 8a2d7d5 ("mirror: Fix features detection for building with clang") we prevented clang to error out when encountering unused command-line arguments in the feature probes, because we do add unused arguments for some of the probes when retrieving arguments from llvm-config, and we don't want probes to fail because of that. At the time, the issue was apparent for the LLVM-based disassembler, so we added -Wno-unused-command-line-argument when $(LLVM) was enabled, only. We missed the case when we're building bpftool with clang instead of gcc, without building the LLVM disassembler. Let's disable the warning unconditionally instead to fix this case. Reported-by: Holger Hoffstätte <[email protected]> Signed-off-by: Quentin Monnet <[email protected]>
1 parent bf9e060 commit 3be8ac3

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/Makefile.feature

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@ pound := \#
44

55
CFLAGS_BACKUP := $(CFLAGS)
66
CFLAGS := $(EXTRA_CFLAGS)
7-
ifneq ($(LLVM),)
8-
CFLAGS += -Wno-unused-command-line-argument
9-
endif
7+
CFLAGS += -Wno-unused-command-line-argument
108

119
ifeq ($(V),1)
1210
LOG=$(warning $(1))

0 commit comments

Comments
 (0)