Skip to content

"Reported", "suspected" S3M quirk is applied near universally in FX_VOLSLIDE. #899

@AliceLR

Description

@AliceLR

This quirk was accidentally triggered by play_rtm_autovib_oob_depth_rate.rtm, which I only discovered by switching the RTM Axy effect to FX_VOLSLIDE2. This "reported" behavior deserves far more scrutiny and, at best, should be limited to S3Ms (and maybe ITs). Delaying to 4.6.5 so that 4.6.4 can be finished sometime this month (maybe).

effects.c:346:

		/* Mirko reports that a S3M with D0F effects created with ST321
		 * should process volume slides in all frames like ST300. I
		 * suspect ST3/IT could be handling D0F effects like this.
		 */
		if (HAS_QUIRK(QUIRK_FINEFX)) {
			if (MSN(xc->vol.memory) == 0xf
			    || LSN(xc->vol.memory) == 0xf) {
				SET(FINE_VOLS);
				xc->vol.fslide = xc->vol.slide;
			}
		}

e01790c

edit: all QUIRK_FINEFX formats are going to have to be tested for this, so S3M, IT, XM, DSMI AMF, DBM, Galaxy 4/5, GDM, IMF, LIQ (both), MDL, PTM, RTM, STM, STX, and possibly some MOD variants.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions