f simplify invalid metadata test

Author: valentinewallace

lightning/src/offers/static_invoice.rs

@@ -856,16 +856,14 @@ mod tests {
 		}
 
 		// Error if the offer's metadata cannot be verified.
-		let mut offer_invalid_signing_pubkey = valid_offer.clone();
-		let mut offer_tlv_stream = offer_invalid_signing_pubkey.as_tlv_stream();
-		let invalid_node_id = payer_pubkey();
-		offer_tlv_stream.node_id = Some(&invalid_node_id);
-		let mut buffer = Vec::new();
-		offer_tlv_stream.write(&mut buffer).unwrap();
-		offer_invalid_signing_pubkey = Offer::try_from(buffer).unwrap();
-
+		let offer = OfferBuilder::new(recipient_pubkey())
+			.path(blinded_path())
+			.metadata(vec![42; 32])
+			.unwrap()
+			.build()
+			.unwrap();
 		if let Err(e) = StaticInvoiceBuilder::for_offer_using_keys(
-			&offer_invalid_signing_pubkey,
+			&offer,
 			payment_paths(),
 			vec![blinded_path()],
 			now,