Skip to content

Commit 3d1a199

Browse files
committed
github: standardize workflow job naming and update comments for clarity
1 parent 9ef2fa8 commit 3d1a199

File tree

1 file changed

+39
-58
lines changed

1 file changed

+39
-58
lines changed

.github/workflows/main.yaml

Lines changed: 39 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,17 @@ defaults:
1616
shell: bash
1717

1818
env:
19-
# go needs absolute directories, using the $HOME variable doesn't work here.
19+
# Go needs absolute directories; using the $HOME variable doesn't work here.
2020
GOPATH: /home/runner/work/go
2121

2222
GO_VERSION: '1.24.9'
23-
23+
2424
LITD_ITEST_BRANCH: 'master'
2525

2626
jobs:
27-
#######################
28-
# sql model generation
29-
#######################
27+
# Validate generated SQL models stay in sync with queries.
3028
sqlc-check:
31-
name: Sqlc check
29+
name: SQLC Model Generation
3230
runs-on: ubuntu-latest
3331
steps:
3432
- name: git checkout
@@ -46,8 +44,9 @@ jobs:
4644
- name: Generate sql models
4745
run: make sqlc-check
4846

47+
# Rebuild RPC stubs and REST annotations to detect drift.
4948
rpc-check:
50-
name: RPC check
49+
name: RPC Stub and REST Annotation Check
5150
runs-on: ubuntu-latest
5251
steps:
5352
- name: git checkout
@@ -61,8 +60,9 @@ jobs:
6160
- name: Generate RPC stubs and check REST annotations
6261
run: make rpc-check
6362

63+
# Ensure go.mod and go.sum remain tidy.
6464
mod-check:
65-
name: go mod check
65+
name: Go Module Tidy Check
6666
runs-on: ubuntu-latest
6767
steps:
6868
- name: git checkout
@@ -76,8 +76,9 @@ jobs:
7676
- name: Run go mod tidy
7777
run: make mod-check
7878

79+
# Confirm deterministic test vectors are up to date.
7980
test-vector-check:
80-
name: test vector check
81+
name: Test Vector Regeneration Check
8182
runs-on: ubuntu-latest
8283
steps:
8384
- name: git checkout
@@ -91,8 +92,9 @@ jobs:
9192
- name: Run test vector creation check
9293
run: make test-vector-check
9394

95+
# Verify database migration numbering and versions.
9496
migration-check:
95-
name: migration version check
97+
name: Database Migration Version Check
9698
runs-on: ubuntu-latest
9799
steps:
98100
- name: git checkout
@@ -101,11 +103,9 @@ jobs:
101103
- name: Run migration check
102104
run: make migration-check
103105

104-
########################
105-
# Compilation check.
106-
########################
106+
# Build the codebase and docs examples to catch compilation regressions.
107107
compile-check:
108-
name: Compilation check
108+
name: Code and Docs Compilation
109109
runs-on: ubuntu-latest
110110
steps:
111111
- name: git checkout
@@ -122,11 +122,9 @@ jobs:
122122
- name: Compile docs examples
123123
run: make build-docs-examples
124124

125-
########################
126-
# sample configuration check
127-
########################
125+
# Guard sample-tapd.conf defaults against accidental drift.
128126
sample-conf-check:
129-
name: sample configuration check
127+
name: Sample Config Defaults
130128
runs-on: ubuntu-latest
131129
steps:
132130
- name: git checkout
@@ -140,11 +138,9 @@ jobs:
140138
- name: check default values in sample-tapd.conf file
141139
run: make sample-conf-check
142140

143-
########################
144-
# Docker build check.
145-
########################
141+
# Smoke test Docker builds for default and dev images.
146142
docker-build-check:
147-
name: Docker build check
143+
name: Docker Build Smoke Tests
148144
runs-on: ubuntu-latest
149145
steps:
150146
- name: git checkout
@@ -167,11 +163,9 @@ jobs:
167163
file: dev.Dockerfile
168164
tags: 'dev-taproot-assets'
169165

170-
########################
171-
# cross compilation
172-
########################
166+
# Cross-compile release binaries across supported targets.
173167
cross-compile:
174-
name: cross compilation (${{ matrix.sys }})
168+
name: Release Cross-Compile (${{ matrix.sys }})
175169
runs-on: ubuntu-latest
176170
strategy:
177171
fail-fast: false
@@ -197,14 +191,12 @@ jobs:
197191
with:
198192
go-version: '${{ env.GO_VERSION }}'
199193

200-
- name: build release for ${{ matrix.sys }}
194+
- name: Build release for ${{ matrix.sys }}
201195
run: make release sys=${{ matrix.sys }}
202196

203-
########################
204-
# Lint check.
205-
########################
197+
# Run the lint suite for static analysis coverage.
206198
lint-check:
207-
name: Lint check
199+
name: Lint Suite
208200
runs-on: ubuntu-latest
209201
steps:
210202
- name: git checkout
@@ -220,11 +212,9 @@ jobs:
220212
- name: run lint
221213
run: make lint
222214

223-
########################
224-
# Format check.
225-
########################
215+
# Enforce formatting consistency.
226216
format-check:
227-
name: Format check
217+
name: Formatting Check
228218
runs-on: ubuntu-latest
229219
steps:
230220
- name: git checkout
@@ -238,11 +228,9 @@ jobs:
238228
- name: run format
239229
run: make fmt
240230

241-
########################
242-
# check PR updates release notes
243-
########################
231+
# Ensure pull requests update release notes unless explicitly skipped.
244232
milestone-check:
245-
name: Check release notes updated
233+
name: Release Notes Gate
246234
runs-on: ubuntu-latest
247235
if: '!contains(github.event.pull_request.labels.*.name, ''no-changelog'')'
248236
steps:
@@ -252,11 +240,9 @@ jobs:
252240
- name: Release notes check
253241
run: scripts/check-release-notes.sh
254242

255-
########################
256-
# run unit tests
257-
########################
243+
# Unit tests with race detection, coverage, and Postgres backend variants.
258244
unit-test:
259-
name: run unit tests
245+
name: Unit Tests - ${{ matrix.unit_type }}
260246
runs-on: ubuntu-latest
261247
strategy:
262248
# Allow other tests in the matrix to continue if one fails.
@@ -275,7 +261,7 @@ jobs:
275261
with:
276262
go-version: '${{ env.GO_VERSION }}'
277263

278-
- name: run ${{ matrix.unit_type }}
264+
- name: Run ${{ matrix.unit_type }}
279265
run: make ${{ matrix.unit_type }}
280266

281267
- name: Send coverage
@@ -288,11 +274,9 @@ jobs:
288274
format: 'golang'
289275
parallel: true
290276

291-
########################
292-
# run integration tests
293-
########################
277+
# Integration tests on SQLite backend.
294278
integration-test:
295-
name: run itests
279+
name: Integration Tests (SQLite)
296280
runs-on: ubuntu-latest
297281
steps:
298282
- name: git checkout
@@ -331,11 +315,9 @@ jobs:
331315
format: 'golang'
332316
parallel: true
333317

334-
########################
335-
# run integration tests with Postgres backend
336-
########################
318+
# Integration tests on Postgres backend.
337319
integration-test-postgres:
338-
name: run itests postgres
320+
name: Integration Tests (Postgres)
339321
runs-on: ubuntu-latest
340322
steps:
341323
- name: git checkout
@@ -374,18 +356,16 @@ jobs:
374356
format: 'golang'
375357
parallel: true
376358

377-
########################
378-
# Run LiTd tests
379-
########################
359+
# LiT integration/unit tests with Taproot Assets replacements.
380360
run-lit:
381-
name: run LiT ${{ matrix.task_name }}
361+
name: LiT Tests - ${{ matrix.task_name }}
382362
runs-on: ubuntu-latest
383363
continue-on-error: true
384364
strategy:
385365
fail-fast: false
386366
matrix:
387367
include:
388-
- task_name: itests custom_channels
368+
- task_name: itests (custom_channels)
389369
run_cmd: make itest icase=custom_channels
390370
- task_name: unit
391371
run_cmd: make unit
@@ -401,8 +381,9 @@ jobs:
401381
working-directory: ./lightning-terminal
402382
run: ${{ matrix.run_cmd }}
403383

404-
# Notify about the completion of all coverage collecting jobs.
384+
# Finalize Coveralls reporting after parallel coverage jobs.
405385
finish:
386+
name: Finalize Coverage Reporting
406387
if: ${{ always() }}
407388
needs: [ unit-test ]
408389
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)