Open to pull requests?

[pribeh]

Great work on this module. I have some suggestions to the markup/styling. Would the maintainers be open to reviewing a pull request with them?

[pribeh]

I'll try to illustrate my suggestions:

• Shift the admin menu to sit above the page layout. This reduces conflict with most designs and ensures high visibility. It also allows for the menu to be responsive much more easily. See attached screen of rough idea. This requires changing the core navbar from fixed to relative position.
• Although the ninja illustration is nice it's an unnecessary flourish that clutters the design. I love great graphic design but a module such as this should probably remain focused squarely on functionality & accessibility. This type of flourish could reside in a contrib theme though.

[pribeh]

[liorkesos]

Hi Thomas,
Thanks for the comments and time spent to mock up.
Because the administration is something most people would do on a laptop or
on a tablet most screens have a wide ratio and that is why we wanted the
left bar positioning.
I like the "active" idea and we might even use it with the left position
admin bar.
Last version made the ninja appear only if you click on the blue bar. and
the interface is minimal only to the icons width.
Lior

On Tue, May 20, 2014 at 5:39 AM, Thomas notifications@github.com wrote:

[image: screen shot 2014-05-19 at 9 59 27 pm]https://cloud.githubusercontent.com/assets/690883/3022388/f56ea406-dfc7-11e3-97e5-6a240fdd13f2.png
[image: screen shot 2014-05-19 at 9 58 06 pm]https://cloud.githubusercontent.com/assets/690883/3022389/f56fc2aa-dfc7-11e3-8a31-5f5bac5265f3.png
[image: screen shot 2014-05-19 at 9 59 11 pm]https://cloud.githubusercontent.com/assets/690883/3022390/f578268e-dfc7-11e3-89ac-85e6764bcdc6.png

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-43580934
.

Lior Kesos - http://www.linnovate.net
Linnovate - Community Infrastructure Care
mail: lior@linnovate.net
office: +972 722500881
cell: +972 524305252
skype: liorkesos

[pribeh]

I have yet to truly examine how the theming system works but I'm curious if it would be possible to more easily override the template (view) and css then to have to modify in the files in the module folder. Is there or could there be a way to override the view for this in the public folder? I don't want to load in that extra markup and image each page load. The current design will also interfere with various designs I'm working on and I'd prefer not to maintain a fork of the project.

[liorkesos]

We (@linnovate) have a lot of experience from the Drupal world - where this
kind of overiding is very common.
Actually being able to changed the views directly rids you from neededing
many overides - we'll defintly look in to this..
Thanks for your participation and ideas!
rock on
Lior

On Tue, May 20, 2014 at 4:04 PM, Thomas notifications@github.com wrote:

I have yet to truly examine how the theming system works but I'm curious
if it would be possible to more easily override the template (view) and css
then to have to modify in the module folder. I just don't want to load in
that extra markup and image each page load.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-43622261
.

Lior Kesos - http://www.linnovate.net
Linnovate - Community Infrastructure Care
mail: lior@linnovate.net
office: +972 722500881
cell: +972 524305252
skype: liorkesos

[image: Namez] http://namez.com/profiles/266-lior-kesos/?autoPlay=true