libibumad: allow choose port with state DOWN in case of explicit user port #1664
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… port Today libibumad rejects ports that are not ACTIVE during selection, which prevents users from targeting a specific port that is administratively DOWN. This change permits selecting a port in DOWN state when the user has explicitly specified the port and the device (e.g., by index/identifier). Automatic port selection behavior is unchanged and will continue to prefer only ACTIVE ports. Validation of the requested port’s existence and basic attributes remains intact. if user explicitly chose device name AND: - port number - port is 0 and device is switch - Only one port for device we skip the verification of port state. This is mainly done to suport opensm standalone feature Fixes: be54b52 ("libibumad: Add new API to support SMI/GSI seperation") Signed-off-by: Asaf Mazor <[email protected]>
mazorasaf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today libibumad rejects ports that are not ACTIVE during selection, which prevents users from targeting a specific port that is administratively DOWN. This change permits selecting a port in DOWN state when the user has explicitly specified the port and the device (e.g., by index/identifier).
Automatic port selection behavior is unchanged and will continue to prefer only ACTIVE ports. Validation of the requested port’s existence and basic attributes remains intact.
if user explicitly chose device name AND:
we skip the verification of port state.
This is mainly done to suport opensm standalone feature
Fixes: be54b52 ("libibumad: Add new API to support SMI/GSI seperation")