Skip to content

Conversation

@sydorovdmytro
Copy link
Contributor

@sydorovdmytro sydorovdmytro commented Nov 10, 2025

Adds a new pipeline to run Ginkgo E2E tests

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #


Note

Adds a GitHub Actions workflow and composite action to build artifacts and run labeled/dir-filtered Ginkgo E2E tests, including install/delete and upgrade checks on kind.

  • CI / Workflows (.github/workflows/e2e-ginkgo.yaml):
    • Adds PR/release/dispatch-triggered E2E pipeline with concurrency control and change-detection gating.
    • Builds vcluster CLI and syncer image (Dockerfile.release, GoReleaser), uploads as artifacts.
    • Validates cluster lifecycle:
      • Install/delete tests via kubectl and helm on kind.
      • Upgrade tests from latest release → dev build across k3s and k8s distros.
    • Executes Ginkgo E2E suites via composite action with label filter parsed from PR body or input; prints diagnostics on failure.
  • Composite Action (.github/actions/run-ginkgo-e2e/action.yml):
    • Supports directory- or label-based test selection; installs Ginkgo, loads artifacts, prunes Docker images.
    • Runs ginkgo with timing/progress flags and JSON report output; passes --vcluster-image to tests.
    • Generates concise failure summary from test-reports/report.json for job outputs.

Written by Cursor Bugbot for commit a6ae2e4. This will update automatically on new commits. Configure here.

Adds a new pipeline to run Ginkgo E2E tests
@adriankabala adriankabala changed the base branch from main to ak_e2e-next-framework November 20, 2025 15:18
@sydorovdmytro sydorovdmytro marked this pull request as ready for review November 20, 2025 15:25
@sydorovdmytro sydorovdmytro requested review from a team and Piotr1215 as code owners November 20, 2025 15:25
@sydorovdmytro sydorovdmytro merged commit 87a7f67 into loft-sh:ak_e2e-next-framework Nov 20, 2025
41 of 42 checks passed
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

"--poll-progress-after=20s"
"--poll-progress-interval=10s"
"--github-output"
"--json-report=${REPORT_PATH}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: JSON report flag contradicts TODO comment

The comment on lines 107-108 states the --json-report flag is "temporarily disabled" due to a nil pointer issue, yet line 117 still includes --json-report=${REPORT_PATH} in the GINKGO_ARGS. This contradicts the documented intent and the TODO comment warning that this flag causes panic. Either remove the flag or remove the misleading comment.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants