Skip to content

Commit 8e14ab1

Browse files
committed
Refactor names of user menu components
1 parent db9544f commit 8e14ab1

File tree

4 files changed

+30
-20
lines changed

4 files changed

+30
-20
lines changed

packages/squared/src/components/GafaelfawrUserMenu/GafaelfawrUserMenu.stories.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ export const Default: Story = {
1919

2020
render: (args) => (
2121
<GafaelfawrUserMenu {...args}>
22-
<GafaelfawrUserMenu.MenuItem>
22+
<GafaelfawrUserMenu.Item>
2323
<a href="#">Account Settings</a>
24-
</GafaelfawrUserMenu.MenuItem>
25-
<GafaelfawrUserMenu.MenuItem>
24+
</GafaelfawrUserMenu.Item>
25+
<GafaelfawrUserMenu.Item>
2626
<a href="#">Security tokens</a>
27-
</GafaelfawrUserMenu.MenuItem>
27+
</GafaelfawrUserMenu.Item>
2828
</GafaelfawrUserMenu>
2929
),
3030
};

packages/squared/src/components/GafaelfawrUserMenu/GafaelfawrUserMenu.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import React from 'react';
33
import styled from 'styled-components';
44

55
import Menu from './Menu';
6+
import Separator from './Separator';
67

78
import MenuItem from './MenuItem';
89

@@ -44,6 +45,8 @@ const SiteNavLink = styled.a`
4445
}
4546
`;
4647

47-
GafaelfawrUserMenu.MenuItem = MenuItem;
48+
// Associate child components with the parent for easier imports.
49+
GafaelfawrUserMenu.Item = MenuItem;
50+
GafaelfawrUserMenu.Separator = Separator;
4851

4952
export default GafaelfawrUserMenu;

packages/squared/src/components/GafaelfawrUserMenu/Menu.tsx

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
import React from 'react';
22
import styled from 'styled-components';
33

4-
import * as DropdownMenu from '@radix-ui/react-dropdown-menu';
4+
import * as RadixDropdownMenu from '@radix-ui/react-dropdown-menu';
55
import { ChevronDown } from 'react-feather';
66

77
import MenuItem from './MenuItem';
8+
import Separator from './Separator';
89

910
export interface MenuProps {
1011
children: React.ReactNode;
@@ -16,25 +17,25 @@ export interface MenuProps {
1617

1718
export const Menu = ({ children, logoutHref }: MenuProps) => {
1819
return (
19-
<DropdownMenu.Root>
20-
<DropdownMenu.Trigger asChild>
20+
<RadixDropdownMenu.Root>
21+
<RadixDropdownMenu.Trigger asChild>
2122
<MenuTriggerButton>
2223
username <ChevronDown />
2324
</MenuTriggerButton>
24-
</DropdownMenu.Trigger>
25+
</RadixDropdownMenu.Trigger>
2526

26-
<DropdownMenu.Portal>
27+
<RadixDropdownMenu.Portal>
2728
<StyledContent align="end" sideOffset={5}>
2829
{children}
2930
<Separator />
3031
<MenuItem>
3132
<a href={logoutHref}>Logout</a>
3233
</MenuItem>
3334

34-
<DropdownMenu.Arrow className="DropdownMenuArrow" />
35+
<RadixDropdownMenu.Arrow className="DropdownMenuArrow" />
3536
</StyledContent>
36-
</DropdownMenu.Portal>
37-
</DropdownMenu.Root>
37+
</RadixDropdownMenu.Portal>
38+
</RadixDropdownMenu.Root>
3839
);
3940
};
4041

@@ -72,7 +73,7 @@ const MenuTriggerButton = styled.button`
7273
/**
7374
* The menu content container, used in a `DropdownMenu.Portal`.
7475
*/
75-
const StyledContent = styled(DropdownMenu.Content)`
76+
const StyledContent = styled(RadixDropdownMenu.Content)`
7677
font-size: 1rem;
7778
background-color: var(--rsd-component-header-nav-menulist-background-color);
7879
min-width: 12rem;
@@ -94,10 +95,4 @@ const StyledContent = styled(DropdownMenu.Content)`
9495
}
9596
`;
9697

97-
const Separator = styled(DropdownMenu.Separator)`
98-
margin: 1rem -1rem;
99-
margin: 0 -1rem 1rem;
100-
border: 1px solid var(--rsd-color-primary-700);
101-
`;
102-
10398
export default Menu;
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import React from 'react';
2+
import styled from 'styled-components';
3+
4+
import * as RadixDropdownMenu from '@radix-ui/react-dropdown-menu';
5+
6+
export const Separator = styled(RadixDropdownMenu.Separator)`
7+
margin: 1rem -1rem;
8+
margin: 0 -1rem 1rem;
9+
border: 1px solid var(--rsd-color-primary-700);
10+
`;
11+
12+
export default Separator;

0 commit comments

Comments
 (0)