-
Notifications
You must be signed in to change notification settings - Fork 420
ci: test on macOS 15 (Intel) #3578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Julien Jerphanion <[email protected]>
|
Thank you for this contribution, @henryiii. Someone with a machine on macOS 13 should dive into this problem. Note that we are only maintaining the distributions of mamba and micromamba on conda-forge, but we aren't against someone maintaining the distributions on Homebrew and upstreaming patches so that mamba and micromamba are portable or more systems. |
|
Any suggestions or thoughts on #3495 ? The problem is that the GHA runs here use the latest LLVM compilers, and not the AppleClang compilers that come with macOS, and systems like homebrew use the AppleClang compilers. I think there are a couple of uses of C++ features that aren't supported by the older compilers. So far it looks pretty easily fixable, I think? Maybe just adding some explicit types instead of using the deduction guidelines. There's also a linux issue there. |
Yes, definitely. New GHA workflows can be set to test Homebrew's toolchains. |
Signed-off-by: Julien Jerphanion <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3578 +/- ##
=======================================
Coverage 63.62% 63.62%
=======================================
Files 300 300
Lines 38159 38159
Branches 2834 2834
=======================================
Hits 24278 24278
Misses 13826 13826
Partials 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@henryiii: using macos-15 resolves the problem but it seems that homebrew's CI uses macos-13, macos-14 and macos-15. Must it use macos-13 and macos-14? I.e. would you accept those changes? |
|
13 is special because it's Intel based. That's what was failing on brew. It's not the last OS to support Intel (I'm on an Intel machine mostly, and am using the latest OS), but it was the last OS they provided with Intel runners (last I checked). I expect macOS-13 to fail, I want it to fail here, because the problem needs to be fixed. Using macOS-13 was supposed to expose the problem that needs fixing. :) |
|
We don't have a macos-13 machine to debug, so we will wait. |
|
Is Homebrew still using |
macOS 13 is a target for homebrew, and still an important target for GHA, as it's the last Intel build they provide. I think on macOS 13 there will be a missing deduction guide error, but will have to see.
FYI, mamba-org/setup-micromamba@v2 is broken, probably see #3576.
(Likewise, I don't think GCC 11 is supported, only 13+)
Versions don't match, this is reporting Clang 17, while the homebrew job is using AppleClang 15.