Bug 2002191 - Align indirect and direct module namespace re-exports r=jonco

marco-c · marco-c · commit effd9e9bd08e · 2025-11-27T19:45:41.000Z
This patch implements tc39/ecma262#3715, to make import * as ns from "mod"; export { ns }; behave the same as export * as ns from "mod"; Tested by tc39/test262#4606 Differential Revision: https://phabricator.services.mozilla.com/D274013 UltraBlame original commit: d14a908552e6d040c7538351430b3152a4a36887
diff --git a/js/src/builtin/ModuleObject.cpp b/js/src/builtin/ModuleObject.cpp
@@ -9338,16 +9338,42 @@ importEntry
 importName
 )
 {
+auto
+entry
+=
+frontend
+:
+:
+StencilModuleEntry
+:
+:
+exportNamespaceFromEntry
+(
+importEntry
+-
+>
+moduleRequest
+exp
+.
+exportName
+exp
+.
+lineno
+exp
+.
+column
+)
+;
 if
 (
 !
 metadata
 .
-localExportEntries
+indirectExportEntries
 .
 append
 (
-exp
+entry
 )
 )
 {

Original file line number	Diff line number	Diff line change
`@@ -9338,16 +9338,42 @@ importEntry`
`9338`	`9338`	`importName`
`9339`	`9339`	`)`
`9340`	`9340`	`{`
	`9341`	`+auto`
	`9342`	`+entry`
	`9343`	`+=`
	`9344`	`+frontend`
	`9345`	`+:`
	`9346`	`+:`
	`9347`	`+StencilModuleEntry`
	`9348`	`+:`
	`9349`	`+:`
	`9350`	`+exportNamespaceFromEntry`
	`9351`	`+(`
	`9352`	`+importEntry`
	`9353`	`+-`
	`9354`	`+>`
	`9355`	`+moduleRequest`
	`9356`	`+exp`
	`9357`	`+.`
	`9358`	`+exportName`
	`9359`	`+exp`
	`9360`	`+.`
	`9361`	`+lineno`
	`9362`	`+exp`
	`9363`	`+.`
	`9364`	`+column`
	`9365`	`+)`
	`9366`	`+;`
`9341`	`9367`	`if`
`9342`	`9368`	`(`
`9343`	`9369`	`!`
`9344`	`9370`	`metadata`
`9345`	`9371`	`.`
`9346`		`-localExportEntries`
	`9372`	`+indirectExportEntries`
`9347`	`9373`	`.`
`9348`	`9374`	`append`
`9349`	`9375`	`(`
`9350`		`-exp`
	`9376`	`+entry`
`9351`	`9377`	`)`
`9352`	`9378`	`)`
`9353`	`9379`	`{`