-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
enhancementNew feature or requestNew feature or requestmajorA large and significant addition or improvementA large and significant addition or improvement
Milestone
Description
One nice generalization of the MA family is allowing a phonon to be created at a larger distance away from the main cloud. This is another one of Mona/Stepan's requests and will be a very nice option for users who wish to implement a more specific type of GGCE.
Particularly, I envision that the model will be passed some extra option kwargs. For example, the new Model.add_ signature might look something like
def add_(
self,
coupling_type,
phonon_frequency,
phonon_extent,
phonon_number,
phonon_extent_tfd=None,
phonon_number_tfd=None,
coupling_strength=None,
dimensionless_coupling_strength=None,
phonon_index_override=None,
secondary_phonon_extent=None, # new!
secondary_phonon_number=None # new!
)Where the parameter secondary_phonon_number will control the number of phonons that are allowed to be "farther away" (where 1 is what was initially suggested, but there's no reason we can't generalize that!), and secondary_phonon_extent will control just how far away from the main cloud these extra phonons can go.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestmajorA large and significant addition or improvementA large and significant addition or improvement