Skip to content

Stack trie inner_fmt is slow #96

@jamesjwu

Description

@jamesjwu

As tlparse outputs get larger, I start noticing that tlparse itself is slow for large (>100MiB) structured logs.

I did a quick profile using cargo flamegraph to see what takes the most time in tlparse (assuming --plain-text).

Here's the flamegraph:

Image

9cfe1d0
adds stack trie mini stacks to every compilation metric page. Turns out, doing this is pretty slow overall.

I think internally, downloading/uploading is still the majority of the time spent in tlparse, so this isn't super urgent. But might worth considering if we can optimize this better (for example, instead of formatting on rust side, we could inject javascript to do the formatting when the user opens the page instead)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions