CsWin32 0.3.228 removes PSID implicit/explicit IntPtr operator overloads.

[mjr4077au]

Actual behavior

The latest update removes these three operator overloads from the PSID class:

public static implicit operator IntPtr(PSID value) => new IntPtr(value.Value);
public static explicit operator PSID(IntPtr value) => new PSID((void*)value.ToPointer());
public static explicit operator PSID(UIntPtr value) => new PSID((void*)value.ToPointer());

It's now a lot harder to construct a SecurityIdentifier object from a PSID.

Expected behavior

PSID pSid = GetPSIDFromSomewhere();
SecurityIdentifier sid = new(pSid);

Repro steps

1. NativeMethods.txt content:
   N/A

2. NativeMethods.json content (if present):
   N/A

3. Any of your own code that should be shared?

Context

• CsWin32 version: 0.3.228
• Win32Metadata version (if explicitly set by project): N/A
• Target Framework: net472
• LangVersion (if explicitly set by project): N/A

[jevansaks]

Looks like this disappeared between 0.3.205 and 0.3.213. @AArnott do you know if there was an intentional change here?

[jevansaks]

Win32Metadata dropped the Free method: https://github.com/microsoft/win32metadata/blob/6c1898d94871a20f497591cf098658e2d35cca75/generation/WinSDK/autoTypes.json#L85

Which then means we don't go through the code that generates implicit IntPtr conversion.

But it seems like the ability to cast all handles implicitly to IntPtr is handy. @AArnott do you know if there's a reason we limit this code to safe handles only?

CsWin32/src/Microsoft.Windows.CsWin32/Generator.TypeDef.cs

Line 117 in 0ca3106

if (isHandle && this.IsSafeHandleCompatibleTypeDefFieldType(fieldTypeInfo) && fieldTypeInfo is not PrimitiveTypeHandleInfo { PrimitiveTypeCode: PrimitiveTypeCode.IntPtr })

[mjr4077au]

Win32Metadata dropped the Free method

Does this mean that FreeSidSafeHandle won't be generated anymore either? This project I noticed the issue on doesn't use that but I have another I haven't updated that uses that type extensively.

[jevansaks]

Actually this type is no longer showing as a HANDLE because it doesn't have a free method anymore. @riverar changed this with microsoft/win32metadata#1988. I'm not sure why CsWin32 doesn't put implicit operator IntPtr on void* typedefs.

[riverar]

Yep, PSID is too broad and cannot participate in RAII because the freeing function may be different across APIs that use it.

Can't speak to the CsWin32 implementation.

[jevansaks]

No FreeSidSafeHandle will be generated because there's no win32metadata that refers to it anymore.

[jevansaks]

Yep, PSID is too broad and cannot participate in RAII because the freeing function may be different across APIs that use it.

Can't speak to the CsWin32 implementation.

@riverar I can't tell what you're implying. Do other projections generate an RAII helper even though there's nothing in the metadata that would indicate there's a link between PSID and FreePsid?

[riverar]

Oh. I was just providing some context to my PR you linked to. PSIDs returned by AllocateAndInitializeSid are freed via FreeSid while PSIDs returned by ConvertStringSidToSid are freed via LocalFree.

Not related to your implicit operator request here!

[jevansaks]

@riverar we should still have an issue on win32metadata that those functions need their out parameters annotated correctly for their RAII functions.