User/kythant/exception handling

src/Tests/AuthoringConsumptionTest/AuthoringConsumptionTest.vcxproj.filters

@@ -1,39 +1,39 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <ItemGroup>
-    <Filter Include="Source Files">
-      <UniqueIdentifier>{4FC737F1-C7A5-4376-A066-2A32D752A2FF}</UniqueIdentifier>
-      <Extensions>cpp;c;cc;cxx;def;odl;idl;hpj;bat;asm;asmx</Extensions>
-    </Filter>
-    <Filter Include="Header Files">
-      <UniqueIdentifier>{93995380-89BD-4b04-88EB-625FBE52EBFB}</UniqueIdentifier>
-      <Extensions>h;hh;hpp;hxx;hm;inl;inc;xsd</Extensions>
-    </Filter>
-    <Filter Include="Resource Files">
-      <UniqueIdentifier>{67DA6AB6-F800-4c08-8B7A-83BB121AAD01}</UniqueIdentifier>
-      <Extensions>rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx;tiff;tif;png;wav;mfcribbon-ms</Extensions>
-    </Filter>
-  </ItemGroup>
-  <ItemGroup>
-    <ClInclude Include="pch.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
-  </ItemGroup>
-  <ItemGroup>
-    <ClCompile Include="pch.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
-    <ClCompile Include="test.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
-  </ItemGroup>
-  <ItemGroup>
-    <None Include="packages.config" />
-    <None Include="Directory.Build.targets" />
-    <None Include="WinRT.Host.runtimeconfig.json" />
-    <None Include="DoNotImport_MsAppxPackageTargets.targets" />
-  </ItemGroup>
-  <ItemGroup>
-    <Manifest Include="AuthoringConsumptionTest.exe.manifest" />
-  </ItemGroup>
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <ItemGroup>
+    <Filter Include="Source Files">
+      <UniqueIdentifier>{4FC737F1-C7A5-4376-A066-2A32D752A2FF}</UniqueIdentifier>
+      <Extensions>cpp;c;cc;cxx;def;odl;idl;hpj;bat;asm;asmx</Extensions>
+    </Filter>
+    <Filter Include="Header Files">
+      <UniqueIdentifier>{93995380-89BD-4b04-88EB-625FBE52EBFB}</UniqueIdentifier>
+      <Extensions>h;hh;hpp;hxx;hm;inl;inc;xsd</Extensions>
+    </Filter>
+    <Filter Include="Resource Files">
+      <UniqueIdentifier>{67DA6AB6-F800-4c08-8B7A-83BB121AAD01}</UniqueIdentifier>
+      <Extensions>rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx;tiff;tif;png;wav;mfcribbon-ms</Extensions>
+    </Filter>
+  </ItemGroup>
+  <ItemGroup>
+    <ClInclude Include="pch.h">
+      <Filter>Header Files</Filter>
+    </ClInclude>
+  </ItemGroup>
+  <ItemGroup>
+    <ClCompile Include="pch.cpp">
+      <Filter>Source Files</Filter>
+    </ClCompile>
+    <ClCompile Include="test.cpp">
+      <Filter>Source Files</Filter>
+    </ClCompile>
+  </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+    <None Include="Directory.Build.targets" />
+    <None Include="WinRT.Host.runtimeconfig.json" />
+    <None Include="DoNotImport_MsAppxPackageTargets.targets" />
+  </ItemGroup>
+  <ItemGroup>
+    <Manifest Include="AuthoringConsumptionTest.exe.manifest" />
+  </ItemGroup>
 </Project>

src/Tests/TestComponentCSharp/ManualProjectionTestClasses.cpp

@@ -34,6 +34,8 @@ namespace winrt::TestComponentCSharp::implementation
 
 	void CustomDisposableTest::Close()
 	{
+        // Leaving in for testing purposes
+        // throw winrt::hresult_access_denied();
 	}
 
     CustomBindableVectorTest::CustomBindableVectorTest()

src/WinRT.Runtime/IInspectable.net5.cs

@@ -15,21 +15,21 @@ partial class IInspectable : IWinRTObject
     {
         IObjectReference IWinRTObject.NativeObject => _obj;
         bool IWinRTObject.HasUnwrappableNativeObject => true;
-       
+
         private volatile ConcurrentDictionary<RuntimeTypeHandle, IObjectReference> _queryInterfaceCache;
         private ConcurrentDictionary<RuntimeTypeHandle, IObjectReference> MakeQueryInterfaceCache()
         {
-            System.Threading.Interlocked.CompareExchange(ref _queryInterfaceCache, new ConcurrentDictionary<RuntimeTypeHandle, IObjectReference>(), null); 
+            System.Threading.Interlocked.CompareExchange(ref _queryInterfaceCache, new ConcurrentDictionary<RuntimeTypeHandle, IObjectReference>(), null);
             return _queryInterfaceCache;
         }
         ConcurrentDictionary<RuntimeTypeHandle, IObjectReference> IWinRTObject.QueryInterfaceCache => _queryInterfaceCache ?? MakeQueryInterfaceCache();
         private volatile ConcurrentDictionary<RuntimeTypeHandle, object> _additionalTypeData;
         private ConcurrentDictionary<RuntimeTypeHandle, object> MakeAdditionalTypeData()
         {
-            System.Threading.Interlocked.CompareExchange(ref _additionalTypeData, new ConcurrentDictionary<RuntimeTypeHandle, object>(), null); 
+            System.Threading.Interlocked.CompareExchange(ref _additionalTypeData, new ConcurrentDictionary<RuntimeTypeHandle, object>(), null);
             return _additionalTypeData;
         }
         ConcurrentDictionary<RuntimeTypeHandle, object> IWinRTObject.AdditionalTypeData => _additionalTypeData ?? MakeAdditionalTypeData();
     }
 
-}
+}

src/WinRT.Runtime2/ABI/System/Exception.cs

@@ -70,7 +70,7 @@ public static Exception ConvertToUnmanaged(global::System.Exception? value)
     /// <returns>The managed <see cref="global::System.Exception"/> value</returns>
     public static global::System.Exception? ConvertToManaged(Exception value)
     {
-        return RestrictedErrorInfo.GetExceptionForHR(value.Value);
+        return RestrictedErrorInfo.GetExceptionForHR(value.Value, out _);
     }
 }
 

src/WinRT.Runtime2/Exceptions/Microsoft.UI.Xaml/ElementNotAvailableException.cs

@@ -0,0 +1,38 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using System;
+using WindowsRuntime.InteropServices;
+
+namespace Microsoft.UI.Xaml;
+
+/// <summary>
+/// Represents an exception that occurs when an element is not available.
+/// </summary>
+/// <remarks>
+/// Sets <see cref="Exception.HResult"/> to <see cref="WellKnownErrorCodes.E_ELEMENTNOTAVAILABLE"/>
+/// to enable consistent interop/error mapping.
+/// </remarks>
+internal sealed class ElementNotAvailableException : Exception
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ElementNotAvailableException"/> class
+    /// with a default error message indicating the element is not available.
+    /// </summary>
+    public ElementNotAvailableException()
+        : base("The element is not available.")
+    {
+        HResult = WellKnownErrorCodes.E_ELEMENTNOTAVAILABLE;
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ElementNotAvailableException"/> class
+    /// with a specified error message.
+    /// </summary>
+    /// <param name="message">The error message that explains the reason for the exception.</param>
+    public ElementNotAvailableException(string message)
+        : base(message)
+    {
+        HResult = WellKnownErrorCodes.E_ELEMENTNOTAVAILABLE;
+    }
+}

src/WinRT.Runtime2/Exceptions/Microsoft.UI.Xaml/ElementNotEnabledException.cs

@@ -0,0 +1,38 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using System;
+using WindowsRuntime.InteropServices;
+
+namespace Microsoft.UI.Xaml;
+
+/// <summary>
+/// Represents an exception that occurs when an element is not enabled.
+/// </summary>
+/// <remarks>
+/// Sets <see cref="Exception.HResult"/> to <see cref="WellKnownErrorCodes.E_ELEMENTNOTENABLED"/>
+/// to enable consistent interop/error mapping.
+/// </remarks>
+internal sealed class ElementNotEnabledException : Exception
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ElementNotEnabledException"/> class
+    /// with a default error message indicating the element is not enabled.
+    /// </summary>
+    public ElementNotEnabledException()
+        : base("The element is not enabled.")
+    {
+        HResult = WellKnownErrorCodes.E_ELEMENTNOTENABLED;
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ElementNotEnabledException"/> class
+    /// with a specified error message.
+    /// </summary>
+    /// <param name="message">The error message that explains the reason for the exception.</param>
+    public ElementNotEnabledException(string message)
+        : base(message)
+    {
+        HResult = WellKnownErrorCodes.E_ELEMENTNOTENABLED;
+    }
+}

src/WinRT.Runtime2/Exceptions/Microsoft.UI.Xaml/LayoutCycleException.cs

@@ -0,0 +1,38 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using System;
+using WindowsRuntime.InteropServices;
+
+namespace Microsoft.UI.Xaml;
+
+/// <summary>
+/// Represents an exception that occurs when a layout cycle is detected during GUI layout.
+/// </summary>
+/// <remarks>
+/// Sets <see cref="Exception.HResult"/> to <see cref="WellKnownErrorCodes.E_LAYOUTCYCLE"/>
+/// to enable consistent interop/error mapping.
+/// </remarks>
+internal sealed class LayoutCycleException : Exception
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="LayoutCycleException"/> class
+    /// with a default error message indicating a layout cycle occurred.
+    /// </summary>
+    public LayoutCycleException()
+        : base("A cycle occurred while laying out the GUI.")
+    {
+        HResult = WellKnownErrorCodes.E_LAYOUTCYCLE;
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="LayoutCycleException"/> class
+    /// with a specified error message.
+    /// </summary>
+    /// <param name="message">The error message that explains the reason for the exception.</param>
+    public LayoutCycleException(string message)
+        : base(message)
+    {
+        HResult = WellKnownErrorCodes.E_LAYOUTCYCLE;
+    }
+}

src/WinRT.Runtime2/Exceptions/Microsoft.UI.Xaml/XamlParseException.cs

@@ -0,0 +1,38 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using System;
+using WindowsRuntime.InteropServices;
+
+namespace Microsoft.UI.Xaml;
+
+/// <summary>
+/// Represents an exception that occurs when XAML parsing fails.
+/// </summary>
+/// <remarks>
+/// Sets <see cref="Exception.HResult"/> to <see cref="WellKnownErrorCodes.E_XAMLPARSEFAILED"/>
+/// to enable consistent interop/error mapping.
+/// </remarks>
+internal sealed class XamlParseException : Exception
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="XamlParseException"/> class
+    /// with a default error message indicating XAML parsing failure.
+    /// </summary>
+    public XamlParseException()
+        : base("XAML parsing failed.")
+    {
+        HResult = WellKnownErrorCodes.E_XAMLPARSEFAILED;
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="XamlParseException"/> class
+    /// with a specified error message.
+    /// </summary>
+    /// <param name="message">The error message that explains the reason for the exception.</param>
+    public XamlParseException(string message)
+        : base(message)
+    {
+        HResult = WellKnownErrorCodes.E_XAMLPARSEFAILED;
+    }
+}

src/WinRT.Runtime2/Exceptions/Windows.UI.Xaml/ElementNotAvailableException.cs

@@ -0,0 +1,38 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using System;
+using WindowsRuntime.InteropServices;
+
+namespace Windows.UI.Xaml;
+
+/// <summary>
+/// Represents an exception that occurs when an element is not available.
+/// </summary>
+/// <remarks>
+/// Sets <see cref="Exception.HResult"/> to <see cref="WellKnownErrorCodes.E_ELEMENTNOTAVAILABLE"/>
+/// to enable consistent interop/error mapping.
+/// </remarks>
+internal sealed class ElementNotAvailableException : Exception
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ElementNotAvailableException"/> class
+    /// with a default error message indicating the element is not available.
+    /// </summary>
+    public ElementNotAvailableException()
+        : base("The element is not available.")
+    {
+        HResult = WellKnownErrorCodes.E_ELEMENTNOTAVAILABLE;
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ElementNotAvailableException"/> class
+    /// with a specified error message.
+    /// </summary>
+    /// <param name="message">The error message that explains the reason for the exception.</param>
+    public ElementNotAvailableException(string message)
+        : base(message)
+    {
+        HResult = WellKnownErrorCodes.E_ELEMENTNOTAVAILABLE;
+    }
+}

src/WinRT.Runtime2/Exceptions/Windows.UI.Xaml/ElementNotEnabledException.cs

@@ -0,0 +1,38 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using System;
+using WindowsRuntime.InteropServices;
+
+namespace Windows.UI.Xaml;
+
+/// <summary>
+/// Represents an exception that occurs when an element is not enabled.
+/// </summary>
+/// <remarks>
+/// Sets <see cref="Exception.HResult"/> to <see cref="WellKnownErrorCodes.E_ELEMENTNOTENABLED"/>
+/// to enable consistent interop/error mapping.
+/// </remarks>
+internal sealed class ElementNotEnabledException : Exception
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ElementNotEnabledException"/> class
+    /// with a default error message indicating the element is not enabled.
+    /// </summary>
+    public ElementNotEnabledException()
+        : base("The element is not enabled.")
+    {
+        HResult = WellKnownErrorCodes.E_ELEMENTNOTENABLED;
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ElementNotEnabledException"/> class
+    /// with a specified error message.
+    /// </summary>
+    /// <param name="message">The error message that explains the reason for the exception.</param>
+    public ElementNotEnabledException(string message)
+        : base(message)
+    {
+        HResult = WellKnownErrorCodes.E_ELEMENTNOTENABLED;
+    }
+}

src/WinRT.Runtime2/Exceptions/Windows.UI.Xaml/LayoutCycleException.cs

@@ -0,0 +1,38 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using System;
+using WindowsRuntime.InteropServices;
+
+namespace Windows.UI.Xaml;
+
+/// <summary>
+/// Represents an exception that occurs when a layout cycle is detected during GUI layout.
+/// </summary>
+/// <remarks>
+/// Sets <see cref="Exception.HResult"/> to <see cref="WellKnownErrorCodes.E_LAYOUTCYCLE"/>
+/// to enable consistent interop/error mapping.
+/// </remarks>
+internal sealed class LayoutCycleException : Exception
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="LayoutCycleException"/> class
+    /// with a default error message indicating a layout cycle occurred.
+    /// </summary>
+    public LayoutCycleException()
+        : base("A cycle occurred while laying out the GUI.")
+    {
+        HResult = WellKnownErrorCodes.E_LAYOUTCYCLE;
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="LayoutCycleException"/> class
+    /// with a specified error message.
+    /// </summary>
+    /// <param name="message">The error message that explains the reason for the exception.</param>
+    public LayoutCycleException(string message)
+        : base(message)
+    {
+        HResult = WellKnownErrorCodes.E_LAYOUTCYCLE;
+    }
+}