Project classes implementing generics and Project arrays #2096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
manodasanW
commented
Oct 28, 2025
manodasanW
commented
- Added support for projecting classes implementing generics
- Added support for projecting arrays
- Ported all the additions to the new format.
- To avoid having them as all manual projections, I added support for partial additions which basically cswinrt will generate the type with partial and we will add the addition as another partial type. This is mostly for types which just had a custom ToString that they wanted to add.
- Enabled all the projections and address issues encountered.
- Moved most event sources to respective ABI namespace to avoid hard coding in cswinrt.exe
Sergio0694
requested changes
Oct 28, 2025
Member
Sergio0694
left a comment
Sergio0694
left a comment
There was a problem hiding this comment.
Did a first partial pass, left some notes for now 🙂
src/Projections/Windows.UI.Xaml/ABI.Windows.System/DispatcherQueueProxyHandler.cs
Outdated
Show resolved
Hide resolved
src/cswinrt/strings/additions/Windows.Storage.Streams/WellKnownStreamInterfaceIIDs.cs
Outdated
Show resolved
Hide resolved
src/WinRT.Runtime2/InteropServices/ProjectionDllExports/TokenizerHelper.cs
Show resolved
Hide resolved
...osoft.UI.Xaml.Controls.Primitives/Microsoft.UI.Xaml.Controls.Primitives.GeneratorPosition.cs
Outdated
Show resolved
Hide resolved
...itions/Microsoft.UI.Xaml.Media.Animation/Microsoft.UI.Xaml.Media.Animation.RepeatBehavior.cs
Outdated
Show resolved
Hide resolved
|
|
||
| case RepeatBehaviorType.Count: | ||
|
|
||
| global::System.Text.StringBuilder sb = new global::System.Text.StringBuilder(); |
Member
There was a problem hiding this comment.
Also we should set SkipLocalsInit for all projection .dlls if we don't already. At least the merged .dll, as we own it.
Member
Author
There was a problem hiding this comment.
Will handler later once we have merged dll
...trings/additions/Microsoft.UI.Xaml.Media.Media3D/Microsoft.UI.Xaml.Media.Media3D.Matrix3D.cs
Outdated
Show resolved
Hide resolved
| // the transform is identity by default | ||
| private static Matrix s_identity = CreateIdentity(); | ||
|
|
||
| public static Matrix Identity |
Member
There was a problem hiding this comment.
@tannergooding is there something smart we could do here like creating a BCL matrix and reinterpreting it or something, rather than storing this value in a static field like this?
Sergio0694
requested changes
Oct 29, 2025
Sergio0694
requested changes
Oct 30, 2025
...trings/additions/Microsoft.UI.Xaml.Media.Media3D/Microsoft.UI.Xaml.Media.Media3D.Matrix3D.cs
Outdated
Show resolved
Hide resolved
src/cswinrt/strings/additions/Microsoft.UI.Xaml.Media/Microsoft.UI.Xaml.Media.Matrix.cs
Show resolved
Hide resolved
manodasanW
force-pushed
the
manodasanw/generics
branch
from
1a2c76d to
e185e84
Compare
Sergio0694
approved these changes
Nov 5, 2025
Member
Sergio0694
left a comment
Sergio0694
left a comment
There was a problem hiding this comment.
Checked the projection .dll too, looks great!! 🎉
| /// </summary> | ||
| /// <param name="exception">The input <see cref="Exception"/> instance to attach the error info to.</param> | ||
| /// <returns>The input <see cref="Exception"/> instance with attached error info.</returns> | ||
| public static Exception AttachErrorInfo(Exception exception) |
Member
There was a problem hiding this comment.
Is this only meant to be used by projections? I'm thinking if so we might want to mark this one and the other ones in RestrictedErrorInfo that are not for general use as private implementation detail methods (or move them).
Member
Author
There was a problem hiding this comment.
Will address in upcoming PR.
src/WinRT.Runtime2/InteropServices/Collections/IObservableMapMethodsImpl{TKey, TValue}.cs
Outdated
Show resolved
Hide resolved
src/WinRT.Runtime2/InteropServices/Collections/IObservableVectorMethodsImpl{T}.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.