Skip to content

Commit 6a361cb

Browse files
Fredrik Orderudforderud
authored andcommitted
Flicker app: Postpone variable definitions until first use
Motivation: Improves readability and maintainability.
1 parent 1b58b0d commit 6a361cb

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

hid/firefly/app/firefly.cpp

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,8 @@ main(
3636
_In_reads_(argc) PCHAR argv[]
3737
)
3838
{
39-
int i, j, k;
4039
BOOL bAdjustLight = FALSE;
41-
BOOL bSuccessful;
4240
ULONG lightSetting = 0;
43-
CLuminous *luminous;
4441

4542
if (argc == 2) {
4643

@@ -60,7 +57,7 @@ main(
6057
exit(0);
6158
}
6259

63-
luminous = new CLuminous();
60+
CLuminous *luminous = new CLuminous();
6461

6562
if (luminous == NULL) {
6663

@@ -75,6 +72,7 @@ main(
7572
return 0;
7673
}
7774

75+
BOOL bSuccessful;
7876
if (bAdjustLight) {
7977

8078
if (lightSetting < 2) {
@@ -91,10 +89,9 @@ main(
9189
}
9290

9391
} else {
94-
95-
k=0;
96-
j=1;
97-
for(i = 500; (i>0)&&(j>0); i-=j) {
92+
int k=0;
93+
int j=1;
94+
for(int i = 500; (i>0)&&(j>0); i-=j) {
9895

9996
j = (i*9/100);
10097
Sleep(i);
@@ -104,7 +101,7 @@ main(
104101
}
105102
k=1-k;
106103
}
107-
for(i = 12; i<500; i+=j) {
104+
for(int i = 12; i<500; i+=j) {
108105

109106
j = (i*9/100);
110107
Sleep(i);

0 commit comments

Comments
 (0)