Skip to content

Commit 6f17c99

Browse files
committed
pr feedback
1 parent 288c74b commit 6f17c99

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/Microsoft.ComponentDetection.Common/FileUtilityService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public Stream MakeFileStream(string fileName)
4747
var linesToKeep = new List<string>();
4848
foreach (var line in File.ReadLines(fileName))
4949
{
50-
if (line == null || removalIndicators.Any(removalIndicator => line.Trim().StartsWith(removalIndicator, System.StringComparison.OrdinalIgnoreCase)))
50+
if (string.IsNullOrEmpty(line) || removalIndicators.Any(removalIndicator => line.Trim().StartsWith(removalIndicator, System.StringComparison.OrdinalIgnoreCase)))
5151
{
5252
removedAnyLines = true;
5353
}

src/Microsoft.ComponentDetection.Detectors/Microsoft.ComponentDetection.Detectors.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2-
2+
33
<ItemGroup>
44
<PackageReference Include="DotNet.Glob" />
55
<PackageReference Include="Microsoft.Extensions.Logging" />
@@ -14,7 +14,7 @@
1414
<PackageReference Include="System.Reactive" />
1515
<PackageReference Include="System.Threading.Tasks.Dataflow" />
1616
<PackageReference Include="Tomlyn.Signed" />
17-
<PackageReference Include="Valleysoft.DockerfileModel " />
17+
<PackageReference Include="Valleysoft.DockerfileModel" />
1818

1919
<!-- Fix alerts -->
2020
<PackageReference Include="System.Formats.Asn1" />

test/Microsoft.ComponentDetection.Common.Tests/Microsoft.ComponentDetection.Common.Tests.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
<PackageReference Include="FluentAssertions.Analyzers" PrivateAssets="all" />
1010
<PackageReference Include="Microsoft.Extensions.Logging" />
1111
<PackageReference Include="System.Threading.Tasks.Dataflow" />
12-
<PackageReference Include="MSTest.TestAdapter " />
13-
<PackageReference Include="Microsoft.NET.Test.Sdk " />
12+
<PackageReference Include="MSTest.TestAdapter" />
13+
<PackageReference Include="Microsoft.NET.Test.Sdk" />
1414
</ItemGroup>
1515

1616
<ItemGroup>

0 commit comments

Comments
 (0)