Use value types to implicitly construct copied arguments

Author: wravery

samples/client/multiple/MultipleQueriesClient.cpp

@@ -126,7 +126,11 @@ static const std::array<std::string_view, 4> s_namesTaskState = {
 	"Unassigned"sv,
 };
 
-CompleteTaskInput::CompleteTaskInput(response::IdType&& idArg, std::optional<TaskState>&& testTaskStateArg, std::optional<bool>&& isCompleteArg, std::optional<std::string>&& clientMutationIdArg) noexcept
+CompleteTaskInput::CompleteTaskInput(
+		response::IdType idArg,
+		std::optional<TaskState> testTaskStateArg,
+		std::optional<bool> isCompleteArg,
+		std::optional<std::string> clientMutationIdArg) noexcept
 	: id { std::move(idArg) }
 	, testTaskState { std::move(testTaskStateArg) }
 	, isComplete { std::move(isCompleteArg) }

samples/client/multiple/MultipleQueriesClient.h

@@ -127,7 +127,11 @@ enum class [[nodiscard]] TaskState
 
 struct [[nodiscard]] CompleteTaskInput
 {
-	explicit CompleteTaskInput(response::IdType&& idArg = response::IdType {}, std::optional<TaskState>&& testTaskStateArg = std::optional<TaskState> {}, std::optional<bool>&& isCompleteArg = std::optional<bool> {}, std::optional<std::string>&& clientMutationIdArg = std::optional<std::string> {}) noexcept;
+	explicit CompleteTaskInput(
+		response::IdType idArg = response::IdType {},
+		std::optional<TaskState> testTaskStateArg = std::optional<TaskState> {},
+		std::optional<bool> isCompleteArg = std::optional<bool> {},
+		std::optional<std::string> clientMutationIdArg = std::optional<std::string> {}) noexcept;
 	CompleteTaskInput(const CompleteTaskInput& other);
 	CompleteTaskInput(CompleteTaskInput&& other) noexcept;
 

samples/client/mutate/MutateClient.cpp

@@ -59,7 +59,11 @@ static const std::array<std::string_view, 4> s_namesTaskState = {
 	"Unassigned"sv,
 };
 
-CompleteTaskInput::CompleteTaskInput(response::IdType&& idArg, std::optional<TaskState>&& testTaskStateArg, std::optional<bool>&& isCompleteArg, std::optional<std::string>&& clientMutationIdArg) noexcept
+CompleteTaskInput::CompleteTaskInput(
+		response::IdType idArg,
+		std::optional<TaskState> testTaskStateArg,
+		std::optional<bool> isCompleteArg,
+		std::optional<std::string> clientMutationIdArg) noexcept
 	: id { std::move(idArg) }
 	, testTaskState { std::move(testTaskStateArg) }
 	, isComplete { std::move(isCompleteArg) }

samples/client/mutate/MutateClient.h

@@ -60,7 +60,11 @@ enum class [[nodiscard]] TaskState
 
 struct [[nodiscard]] CompleteTaskInput
 {
-	explicit CompleteTaskInput(response::IdType&& idArg = response::IdType {}, std::optional<TaskState>&& testTaskStateArg = std::optional<TaskState> {}, std::optional<bool>&& isCompleteArg = std::optional<bool> {}, std::optional<std::string>&& clientMutationIdArg = std::optional<std::string> {}) noexcept;
+	explicit CompleteTaskInput(
+		response::IdType idArg = response::IdType {},
+		std::optional<TaskState> testTaskStateArg = std::optional<TaskState> {},
+		std::optional<bool> isCompleteArg = std::optional<bool> {},
+		std::optional<std::string> clientMutationIdArg = std::optional<std::string> {}) noexcept;
 	CompleteTaskInput(const CompleteTaskInput& other);
 	CompleteTaskInput(CompleteTaskInput&& other) noexcept;
 

samples/client/nestedinput/NestedInputClient.cpp

@@ -46,7 +46,8 @@ const peg::ast& GetRequestObject() noexcept
 	return s_request;
 }
 
-InputA::InputA(bool&& aArg) noexcept
+InputA::InputA(
+		bool aArg) noexcept
 	: a { std::move(aArg) }
 {
 }
@@ -79,7 +80,8 @@ InputA& InputA::operator=(InputA&& other) noexcept
 	return *this;
 }
 
-InputB::InputB(double&& bArg) noexcept
+InputB::InputB(
+		double bArg) noexcept
 	: b { std::move(bArg) }
 {
 }
@@ -112,7 +114,11 @@ InputB& InputB::operator=(InputB&& other) noexcept
 	return *this;
 }
 
-InputABCD::InputABCD(std::string&& dArg, InputA&& aArg, InputB&& bArg, std::vector<InputBC>&& bcArg) noexcept
+InputABCD::InputABCD(
+		std::string dArg,
+		InputA aArg,
+		InputB bArg,
+		std::vector<InputBC> bcArg) noexcept
 	: d { std::move(dArg) }
 	, a { std::move(aArg) }
 	, b { std::move(bArg) }
@@ -154,7 +160,9 @@ InputABCD& InputABCD::operator=(InputABCD&& other) noexcept
 	return *this;
 }
 
-InputBC::InputBC(response::IdType&& cArg, InputB&& bArg) noexcept
+InputBC::InputBC(
+		response::IdType cArg,
+		InputB bArg) noexcept
 	: c { std::move(cArg) }
 	, b { std::move(bArg) }
 {

samples/client/nestedinput/NestedInputClient.h

@@ -46,7 +46,8 @@ namespace nestedinput {
 
 struct [[nodiscard]] InputA
 {
-	explicit InputA(bool&& aArg = bool {}) noexcept;
+	explicit InputA(
+		bool aArg = bool {}) noexcept;
 	InputA(const InputA& other);
 	InputA(InputA&& other) noexcept;
 
@@ -58,7 +59,8 @@ struct [[nodiscard]] InputA
 
 struct [[nodiscard]] InputB
 {
-	explicit InputB(double&& bArg = double {}) noexcept;
+	explicit InputB(
+		double bArg = double {}) noexcept;
 	InputB(const InputB& other);
 	InputB(InputB&& other) noexcept;
 
@@ -72,7 +74,11 @@ struct InputBC;
 
 struct [[nodiscard]] InputABCD
 {
-	explicit InputABCD(std::string&& dArg = std::string {}, InputA&& aArg = InputA {}, InputB&& bArg = InputB {}, std::vector<InputBC>&& bcArg = std::vector<InputBC> {}) noexcept;
+	explicit InputABCD(
+		std::string dArg = std::string {},
+		InputA aArg = InputA {},
+		InputB bArg = InputB {},
+		std::vector<InputBC> bcArg = std::vector<InputBC> {}) noexcept;
 	InputABCD(const InputABCD& other);
 	InputABCD(InputABCD&& other) noexcept;
 
@@ -87,7 +93,9 @@ struct [[nodiscard]] InputABCD
 
 struct [[nodiscard]] InputBC
 {
-	explicit InputBC(response::IdType&& cArg = response::IdType {}, InputB&& bArg = InputB {}) noexcept;
+	explicit InputBC(
+		response::IdType cArg = response::IdType {},
+		InputB bArg = InputB {}) noexcept;
 	InputBC(const InputBC& other);
 	InputBC(InputBC&& other) noexcept;
 

samples/learn/schema/StarWarsSchema.cpp

@@ -96,7 +96,9 @@ learn::ReviewInput ModifiedArgument<learn::ReviewInput>::convert(const response:
 
 namespace learn {
 
-ReviewInput::ReviewInput(int&& starsArg, std::optional<std::string>&& commentaryArg) noexcept
+ReviewInput::ReviewInput(
+		int starsArg,
+		std::optional<std::string> commentaryArg) noexcept
 	: stars { std::move(starsArg) }
 	, commentary { std::move(commentaryArg) }
 {

samples/learn/schema/StarWarsSchema.h

@@ -53,7 +53,9 @@ enum class [[nodiscard]] Episode
 
 struct [[nodiscard]] ReviewInput
 {
-	explicit ReviewInput(int&& starsArg = int {}, std::optional<std::string>&& commentaryArg = std::optional<std::string> {}) noexcept;
+	explicit ReviewInput(
+		int starsArg = int {},
+		std::optional<std::string> commentaryArg = std::optional<std::string> {}) noexcept;
 	ReviewInput(const ReviewInput& other);
 	ReviewInput(ReviewInput&& other) noexcept;
 

samples/today/nointrospection/TodaySchema.cpp

@@ -227,7 +227,11 @@ today::FirstNestedInput ModifiedArgument<today::FirstNestedInput>::convert(const
 
 namespace today {
 
-CompleteTaskInput::CompleteTaskInput(response::IdType&& idArg, std::optional<TaskState>&& testTaskStateArg, std::optional<bool>&& isCompleteArg, std::optional<std::string>&& clientMutationIdArg) noexcept
+CompleteTaskInput::CompleteTaskInput(
+		response::IdType idArg,
+		std::optional<TaskState> testTaskStateArg,
+		std::optional<bool> isCompleteArg,
+		std::optional<std::string> clientMutationIdArg) noexcept
 	: id { std::move(idArg) }
 	, testTaskState { std::move(testTaskStateArg) }
 	, isComplete { std::move(isCompleteArg) }
@@ -269,7 +273,9 @@ CompleteTaskInput& CompleteTaskInput::operator=(CompleteTaskInput&& other) noexc
 	return *this;
 }
 
-ThirdNestedInput::ThirdNestedInput(response::IdType&& idArg, std::unique_ptr<SecondNestedInput>&& secondArg) noexcept
+ThirdNestedInput::ThirdNestedInput(
+		response::IdType idArg,
+		std::unique_ptr<SecondNestedInput> secondArg) noexcept
 	: id { std::move(idArg) }
 	, second { std::move(secondArg) }
 {
@@ -305,7 +311,8 @@ ThirdNestedInput& ThirdNestedInput::operator=(ThirdNestedInput&& other) noexcept
 	return *this;
 }
 
-FourthNestedInput::FourthNestedInput(response::IdType&& idArg) noexcept
+FourthNestedInput::FourthNestedInput(
+		response::IdType idArg) noexcept
 	: id { std::move(idArg) }
 {
 }
@@ -338,7 +345,8 @@ FourthNestedInput& FourthNestedInput::operator=(FourthNestedInput&& other) noexc
 	return *this;
 }
 
-IncludeNullableSelfInput::IncludeNullableSelfInput(std::unique_ptr<IncludeNullableSelfInput>&& selfArg) noexcept
+IncludeNullableSelfInput::IncludeNullableSelfInput(
+		std::unique_ptr<IncludeNullableSelfInput> selfArg) noexcept
 	: self { std::move(selfArg) }
 {
 }
@@ -371,7 +379,8 @@ IncludeNullableSelfInput& IncludeNullableSelfInput::operator=(IncludeNullableSel
 	return *this;
 }
 
-IncludeNonNullableListSelfInput::IncludeNonNullableListSelfInput(std::vector<IncludeNonNullableListSelfInput>&& selvesArg) noexcept
+IncludeNonNullableListSelfInput::IncludeNonNullableListSelfInput(
+		std::vector<IncludeNonNullableListSelfInput> selvesArg) noexcept
 	: selves { std::move(selvesArg) }
 {
 }
@@ -404,7 +413,19 @@ IncludeNonNullableListSelfInput& IncludeNonNullableListSelfInput::operator=(Incl
 	return *this;
 }
 
-StringOperationFilterInput::StringOperationFilterInput(std::optional<std::vector<StringOperationFilterInput>>&& and_Arg, std::optional<std::vector<StringOperationFilterInput>>&& or_Arg, std::optional<std::string>&& equalArg, std::optional<std::string>&& notEqualArg, std::optional<std::string>&& containsArg, std::optional<std::string>&& notContainsArg, std::optional<std::vector<std::string>>&& inArg, std::optional<std::vector<std::string>>&& notInArg, std::optional<std::string>&& startsWithArg, std::optional<std::string>&& notStartsWithArg, std::optional<std::string>&& endsWithArg, std::optional<std::string>&& notEndsWithArg) noexcept
+StringOperationFilterInput::StringOperationFilterInput(
+		std::optional<std::vector<StringOperationFilterInput>> and_Arg,
+		std::optional<std::vector<StringOperationFilterInput>> or_Arg,
+		std::optional<std::string> equalArg,
+		std::optional<std::string> notEqualArg,
+		std::optional<std::string> containsArg,
+		std::optional<std::string> notContainsArg,
+		std::optional<std::vector<std::string>> inArg,
+		std::optional<std::vector<std::string>> notInArg,
+		std::optional<std::string> startsWithArg,
+		std::optional<std::string> notStartsWithArg,
+		std::optional<std::string> endsWithArg,
+		std::optional<std::string> notEndsWithArg) noexcept
 	: and_ { std::move(and_Arg) }
 	, or_ { std::move(or_Arg) }
 	, equal { std::move(equalArg) }
@@ -470,7 +491,9 @@ StringOperationFilterInput& StringOperationFilterInput::operator=(StringOperatio
 	return *this;
 }
 
-SecondNestedInput::SecondNestedInput(response::IdType&& idArg, ThirdNestedInput&& thirdArg) noexcept
+SecondNestedInput::SecondNestedInput(
+		response::IdType idArg,
+		ThirdNestedInput thirdArg) noexcept
 	: id { std::move(idArg) }
 	, third { std::move(thirdArg) }
 {
@@ -506,7 +529,9 @@ SecondNestedInput& SecondNestedInput::operator=(SecondNestedInput&& other) noexc
 	return *this;
 }
 
-ForwardDeclaredInput::ForwardDeclaredInput(std::unique_ptr<IncludeNullableSelfInput>&& nullableSelfArg, IncludeNonNullableListSelfInput&& listSelvesArg) noexcept
+ForwardDeclaredInput::ForwardDeclaredInput(
+		std::unique_ptr<IncludeNullableSelfInput> nullableSelfArg,
+		IncludeNonNullableListSelfInput listSelvesArg) noexcept
 	: nullableSelf { std::move(nullableSelfArg) }
 	, listSelves { std::move(listSelvesArg) }
 {
@@ -542,7 +567,10 @@ ForwardDeclaredInput& ForwardDeclaredInput::operator=(ForwardDeclaredInput&& oth
 	return *this;
 }
 
-FirstNestedInput::FirstNestedInput(response::IdType&& idArg, SecondNestedInput&& secondArg, ThirdNestedInput&& thirdArg) noexcept
+FirstNestedInput::FirstNestedInput(
+		response::IdType idArg,
+		SecondNestedInput secondArg,
+		ThirdNestedInput thirdArg) noexcept
 	: id { std::move(idArg) }
 	, second { std::move(secondArg) }
 	, third { std::move(thirdArg) }

samples/today/nointrospection/TodaySchema.h

@@ -56,7 +56,11 @@ enum class [[nodiscard]] TaskState
 
 struct [[nodiscard]] CompleteTaskInput
 {
-	explicit CompleteTaskInput(response::IdType&& idArg = response::IdType {}, std::optional<TaskState>&& testTaskStateArg = std::optional<TaskState> {}, std::optional<bool>&& isCompleteArg = std::optional<bool> {}, std::optional<std::string>&& clientMutationIdArg = std::optional<std::string> {}) noexcept;
+	explicit CompleteTaskInput(
+		response::IdType idArg = response::IdType {},
+		std::optional<TaskState> testTaskStateArg = std::optional<TaskState> {},
+		std::optional<bool> isCompleteArg = std::optional<bool> {},
+		std::optional<std::string> clientMutationIdArg = std::optional<std::string> {}) noexcept;
 	CompleteTaskInput(const CompleteTaskInput& other);
 	CompleteTaskInput(CompleteTaskInput&& other) noexcept;
 
@@ -73,7 +77,9 @@ struct SecondNestedInput;
 
 struct [[nodiscard]] ThirdNestedInput
 {
-	explicit ThirdNestedInput(response::IdType&& idArg = response::IdType {}, std::unique_ptr<SecondNestedInput>&& secondArg = std::unique_ptr<SecondNestedInput> {}) noexcept;
+	explicit ThirdNestedInput(
+		response::IdType idArg = response::IdType {},
+		std::unique_ptr<SecondNestedInput> secondArg = std::unique_ptr<SecondNestedInput> {}) noexcept;
 	ThirdNestedInput(const ThirdNestedInput& other);
 	ThirdNestedInput(ThirdNestedInput&& other) noexcept;
 
@@ -86,7 +92,8 @@ struct [[nodiscard]] ThirdNestedInput
 
 struct [[nodiscard]] FourthNestedInput
 {
-	explicit FourthNestedInput(response::IdType&& idArg = response::IdType {}) noexcept;
+	explicit FourthNestedInput(
+		response::IdType idArg = response::IdType {}) noexcept;
 	FourthNestedInput(const FourthNestedInput& other);
 	FourthNestedInput(FourthNestedInput&& other) noexcept;
 
@@ -98,7 +105,8 @@ struct [[nodiscard]] FourthNestedInput
 
 struct [[nodiscard]] IncludeNullableSelfInput
 {
-	explicit IncludeNullableSelfInput(std::unique_ptr<IncludeNullableSelfInput>&& selfArg = std::unique_ptr<IncludeNullableSelfInput> {}) noexcept;
+	explicit IncludeNullableSelfInput(
+		std::unique_ptr<IncludeNullableSelfInput> selfArg = std::unique_ptr<IncludeNullableSelfInput> {}) noexcept;
 	IncludeNullableSelfInput(const IncludeNullableSelfInput& other);
 	IncludeNullableSelfInput(IncludeNullableSelfInput&& other) noexcept;
 
@@ -110,7 +118,8 @@ struct [[nodiscard]] IncludeNullableSelfInput
 
 struct [[nodiscard]] IncludeNonNullableListSelfInput
 {
-	explicit IncludeNonNullableListSelfInput(std::vector<IncludeNonNullableListSelfInput>&& selvesArg = std::vector<IncludeNonNullableListSelfInput> {}) noexcept;
+	explicit IncludeNonNullableListSelfInput(
+		std::vector<IncludeNonNullableListSelfInput> selvesArg = std::vector<IncludeNonNullableListSelfInput> {}) noexcept;
 	IncludeNonNullableListSelfInput(const IncludeNonNullableListSelfInput& other);
 	IncludeNonNullableListSelfInput(IncludeNonNullableListSelfInput&& other) noexcept;
 
@@ -122,7 +131,19 @@ struct [[nodiscard]] IncludeNonNullableListSelfInput
 
 struct [[nodiscard]] StringOperationFilterInput
 {
-	explicit StringOperationFilterInput(std::optional<std::vector<StringOperationFilterInput>>&& and_Arg = std::optional<std::vector<StringOperationFilterInput>> {}, std::optional<std::vector<StringOperationFilterInput>>&& or_Arg = std::optional<std::vector<StringOperationFilterInput>> {}, std::optional<std::string>&& equalArg = std::optional<std::string> {}, std::optional<std::string>&& notEqualArg = std::optional<std::string> {}, std::optional<std::string>&& containsArg = std::optional<std::string> {}, std::optional<std::string>&& notContainsArg = std::optional<std::string> {}, std::optional<std::vector<std::string>>&& inArg = std::optional<std::vector<std::string>> {}, std::optional<std::vector<std::string>>&& notInArg = std::optional<std::vector<std::string>> {}, std::optional<std::string>&& startsWithArg = std::optional<std::string> {}, std::optional<std::string>&& notStartsWithArg = std::optional<std::string> {}, std::optional<std::string>&& endsWithArg = std::optional<std::string> {}, std::optional<std::string>&& notEndsWithArg = std::optional<std::string> {}) noexcept;
+	explicit StringOperationFilterInput(
+		std::optional<std::vector<StringOperationFilterInput>> and_Arg = std::optional<std::vector<StringOperationFilterInput>> {},
+		std::optional<std::vector<StringOperationFilterInput>> or_Arg = std::optional<std::vector<StringOperationFilterInput>> {},
+		std::optional<std::string> equalArg = std::optional<std::string> {},
+		std::optional<std::string> notEqualArg = std::optional<std::string> {},
+		std::optional<std::string> containsArg = std::optional<std::string> {},
+		std::optional<std::string> notContainsArg = std::optional<std::string> {},
+		std::optional<std::vector<std::string>> inArg = std::optional<std::vector<std::string>> {},
+		std::optional<std::vector<std::string>> notInArg = std::optional<std::vector<std::string>> {},
+		std::optional<std::string> startsWithArg = std::optional<std::string> {},
+		std::optional<std::string> notStartsWithArg = std::optional<std::string> {},
+		std::optional<std::string> endsWithArg = std::optional<std::string> {},
+		std::optional<std::string> notEndsWithArg = std::optional<std::string> {}) noexcept;
 	StringOperationFilterInput(const StringOperationFilterInput& other);
 	StringOperationFilterInput(StringOperationFilterInput&& other) noexcept;
 
@@ -145,7 +166,9 @@ struct [[nodiscard]] StringOperationFilterInput
 
 struct [[nodiscard]] SecondNestedInput
 {
-	explicit SecondNestedInput(response::IdType&& idArg = response::IdType {}, ThirdNestedInput&& thirdArg = ThirdNestedInput {}) noexcept;
+	explicit SecondNestedInput(
+		response::IdType idArg = response::IdType {},
+		ThirdNestedInput thirdArg = ThirdNestedInput {}) noexcept;
 	SecondNestedInput(const SecondNestedInput& other);
 	SecondNestedInput(SecondNestedInput&& other) noexcept;
 
@@ -158,7 +181,9 @@ struct [[nodiscard]] SecondNestedInput
 
 struct [[nodiscard]] ForwardDeclaredInput
 {
-	explicit ForwardDeclaredInput(std::unique_ptr<IncludeNullableSelfInput>&& nullableSelfArg = std::unique_ptr<IncludeNullableSelfInput> {}, IncludeNonNullableListSelfInput&& listSelvesArg = IncludeNonNullableListSelfInput {}) noexcept;
+	explicit ForwardDeclaredInput(
+		std::unique_ptr<IncludeNullableSelfInput> nullableSelfArg = std::unique_ptr<IncludeNullableSelfInput> {},
+		IncludeNonNullableListSelfInput listSelvesArg = IncludeNonNullableListSelfInput {}) noexcept;
 	ForwardDeclaredInput(const ForwardDeclaredInput& other);
 	ForwardDeclaredInput(ForwardDeclaredInput&& other) noexcept;
 
@@ -171,7 +196,10 @@ struct [[nodiscard]] ForwardDeclaredInput
 
 struct [[nodiscard]] FirstNestedInput
 {
-	explicit FirstNestedInput(response::IdType&& idArg = response::IdType {}, SecondNestedInput&& secondArg = SecondNestedInput {}, ThirdNestedInput&& thirdArg = ThirdNestedInput {}) noexcept;
+	explicit FirstNestedInput(
+		response::IdType idArg = response::IdType {},
+		SecondNestedInput secondArg = SecondNestedInput {},
+		ThirdNestedInput thirdArg = ThirdNestedInput {}) noexcept;
 	FirstNestedInput(const FirstNestedInput& other);
 	FirstNestedInput(FirstNestedInput&& other) noexcept;