Improve logging for unexpected connection failures in DurableTaskGrpcWorker

YunchuWang · YunchuWang · commit 81bb9bd46e35 · 2025-04-28T17:29:52.000-07:00
diff --git a/client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java b/client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java
@@ -191,7 +191,7 @@ else if (requestType == RequestCase.HEALTHPING)
                 } else if (e.getStatus().getCode() == Status.Code.CANCELLED) {
                     logger.log(Level.INFO, "Durable Task worker has disconnected from {0}.", this.getSidecarAddress()); 
                 } else {
-                    logger.log(Level.WARNING, "Unexpected failure connecting to {0}.", this.getSidecarAddress());
+                    logger.log(Level.WARNING, String.format("Unexpected failure connecting to %s", this.getSidecarAddress()), e);
                 }
 
                 // Retry after 5 seconds

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ else if (requestType == RequestCase.HEALTHPING)`
`191`	`191`	`} else if (e.getStatus().getCode() == Status.Code.CANCELLED) {`
`192`	`192`	`logger.log(Level.INFO, "Durable Task worker has disconnected from {0}.", this.getSidecarAddress());`
`193`	`193`	`} else {`
`194`		`- logger.log(Level.WARNING, "Unexpected failure connecting to {0}.", this.getSidecarAddress());`
	`194`	`+ logger.log(Level.WARNING, String.format("Unexpected failure connecting to %s", this.getSidecarAddress()), e);`
`195`	`195`	`}`
`196`	`196`
`197`	`197`	`// Retry after 5 seconds`