Fixing various test issues for all tests (#208)

Author: YunchuWang

.github/workflows/build-validation.yml

@@ -46,14 +46,27 @@ jobs:
 
       # TODO: Move the sidecar into a central image repository
     - name: Initialize Durable Task Sidecar
-      run: docker run --name durabletask-sidecar -p 4001:4001 --env 'DURABLETASK_SIDECAR_LOGLEVEL=Debug' -d kaibocai/durabletask-sidecar:latest start --backend Emulator
+      run: docker run --name durabletask-sidecar -p 4001:4001 --env 'DURABLETASK_SIDECAR_LOGLEVEL=Debug' -d peterstone2019/durabletask-sidecar:latest start --backend Emulator
+
+    - name: Display Durable Task Sidecar Logs
+      run: nohup docker logs --since=0 durabletask-sidecar > durabletask-sidecar.log 2>&1 &
 
       # wait for 10 seconds, so sidecar container can be fully up, this will avoid intermittent failing issues for integration tests causing by failed to connect to sidecar
     - name: Wait for 10 seconds
       run: sleep 10
 
     - name: Integration Tests with Gradle
-      run: ./gradlew integrationTest
+      run: ./gradlew integrationTest || echo "TEST_FAILED=true" >> $GITHUB_ENV
+      continue-on-error: true
+
+    - name: Kill Durable Task Sidecar
+      run: docker kill durabletask-sidecar
+    
+    - name: Upload Durable Task Sidecar Logs
+      uses: actions/upload-artifact@v4
+      with:
+        name: Durable Task Sidecar Logs
+        path: durabletask-sidecar.log
 
     - name: Archive test report
       uses: actions/upload-artifact@v4
@@ -67,6 +80,10 @@ jobs:
         name: Package
         path: client/build/libs
 
+    - name: Fail the job if tests failed
+      if: env.TEST_FAILED == 'true'
+      run: exit 1
+
   functions-e2e-tests:
 
     needs: build
@@ -124,7 +141,7 @@ jobs:
         uses: gradle/gradle-build-action@v2
 
       - name: Publish to local
-        run: ./gradlew publishToMavenLocal -x sign
+        run: ./gradlew publishToMavenLocal
 
       - name: Build azure functions sample
         run: ./gradlew azureFunctionsPackage

client/build.gradle

@@ -118,6 +118,8 @@ task integrationTest(type: Test) {
     dependsOn build
     shouldRunAfter test
     testLogging.showStandardStreams = true
+
+    ignoreFailures = false
 }
 
 publishing {

client/src/test/java/com/microsoft/durabletask/ErrorHandlingIntegrationTests.java

@@ -7,12 +7,14 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
+import org.junit.jupiter.api.extension.ExtendWith;
 
 import java.time.Duration;
 import java.util.concurrent.TimeoutException;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicInteger;
 
+import org.junit.jupiter.api.BeforeEach;
 import static org.junit.jupiter.api.Assertions.*;
 
 /**
@@ -23,8 +25,15 @@
  * client operations and sends invocation instructions to the DurableTaskWorker).
  */
 @Tag("integration")
+@ExtendWith(TestRetryExtension.class)
 public class ErrorHandlingIntegrationTests extends IntegrationTestBase {
-    @Test
+    @BeforeEach
+    private void startUp() {
+        DurableTaskClient client = new DurableTaskGrpcClientBuilder().build();
+        client.deleteTaskHub();
+    }
+
+    @RetryingTest
     void orchestratorException() throws TimeoutException {
         final String orchestratorName = "OrchestratorWithException";
         final String errorMessage = "Kah-BOOOOOM!!!";
@@ -50,7 +59,7 @@ void orchestratorException() throws TimeoutException {
         }
     }
 
-    @ParameterizedTest
+    @RetryingParameterizedTest
     @ValueSource(booleans = {true, false})
     void activityException(boolean handleException) throws TimeoutException {
         final String orchestratorName = "OrchestratorWithActivityException";
@@ -102,7 +111,7 @@ void activityException(boolean handleException) throws TimeoutException {
         }
     }
 
-    @ParameterizedTest
+    @RetryingParameterizedTest
     @ValueSource(ints = {1, 2, 10})
     public void retryActivityFailures(int maxNumberOfAttempts) throws TimeoutException {
         // There is one task for each activity call and one task between each retry
@@ -116,7 +125,7 @@ public void retryActivityFailures(int maxNumberOfAttempts) throws TimeoutExcepti
         });
     }
 
-    @ParameterizedTest
+    @RetryingParameterizedTest
     @ValueSource(ints = {1, 2, 10})
     public void retryActivityFailuresWithCustomLogic(int maxNumberOfAttempts) throws TimeoutException {
         // This gets incremented every time the retry handler is invoked
@@ -133,7 +142,7 @@ public void retryActivityFailuresWithCustomLogic(int maxNumberOfAttempts) throws
         assertEquals(maxNumberOfAttempts, retryHandlerCalls.get());
     }
 
-    @ParameterizedTest
+    @RetryingParameterizedTest
     @ValueSource(booleans = {true, false})
     void subOrchestrationException(boolean handleException) throws TimeoutException {
         final String orchestratorName = "OrchestrationWithBustedSubOrchestrator";
@@ -183,7 +192,7 @@ void subOrchestrationException(boolean handleException) throws TimeoutException
         }
     }
 
-    @ParameterizedTest
+    @RetryingParameterizedTest
     @ValueSource(ints = {1, 2, 10})
     public void retrySubOrchestratorFailures(int maxNumberOfAttempts) throws TimeoutException {
         // There is one task for each sub-orchestrator call and one task between each retry
@@ -198,7 +207,7 @@ public void retrySubOrchestratorFailures(int maxNumberOfAttempts) throws Timeout
             });
     }
 
-    @ParameterizedTest
+    @RetryingParameterizedTest
     @ValueSource(ints = {1, 2, 10})
     public void retrySubOrchestrationFailuresWithCustomLogic(int maxNumberOfAttempts) throws TimeoutException {
         // This gets incremented every time the retry handler is invoked