Skip to content

Commit 99aef8c

Browse files
committed
Add logging for Durable Task Sidecar and update integration test setup
1 parent ef9d465 commit 99aef8c

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.github/workflows/build-validation.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ jobs:
4848
- name: Initialize Durable Task Sidecar
4949
run: docker run --name durabletask-sidecar -p 4001:4001 --env 'DURABLETASK_SIDECAR_LOGLEVEL=Debug' -d peterstone2019/durabletask-sidecar:latest start --backend Emulator
5050

51+
- name: Display Durable Task Sidecar Logs
52+
run: nohup docker logs --since=0 durabletask-sidecar > durabletask-sidecar.log 2>&1 &
53+
5154
# wait for 10 seconds, so sidecar container can be fully up, this will avoid intermittent failing issues for integration tests causing by failed to connect to sidecar
5255
- name: Wait for 10 seconds
5356
run: sleep 10
@@ -56,8 +59,8 @@ jobs:
5659
run: ./gradlew integrationTest || echo "TEST_FAILED=true" >> $GITHUB_ENV
5760
continue-on-error: true
5861

59-
- name: Display Durable Task Sidecar Logs
60-
run: docker logs -f durabletask-sidecar
62+
- name: Kill Durable Task Sidecar
63+
run: docker kill durabletask-sidecar
6164

6265
- name: Archive test report
6366
uses: actions/upload-artifact@v4

client/src/test/java/com/microsoft/durabletask/ErrorHandlingIntegrationTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import java.util.concurrent.atomic.AtomicBoolean;
1414
import java.util.concurrent.atomic.AtomicInteger;
1515

16+
import org.junit.jupiter.api.BeforeEach;
1617
import static org.junit.jupiter.api.Assertions.*;
1718

1819
/**

0 commit comments

Comments
 (0)