Vendored Frotz code makes Jericho hard to build

[artbristol]

It seems there are compilation issues with newer GCC versions.

The following builds fine, for Debian 12:

docker run -it --rm  --user 1000  -v "$(pwd)":"$(pwd)"   -w "$(pwd)" python:3.11-bookworm bash -c "export HOME=$(pwd); pip install -e ."

But if you use Debian 13:

docker run -it --rm  --user 1000  -v "$(pwd)":"$(pwd)"   -w "$(pwd)" python:3.11-trixie bash -c "export HOME=$(pwd); pip install -e ."

you get the following

      src/ztools/showdict.c:37:58: warning: unused variable ‘length’ [-Wunused-variable]
         37 |     unsigned int separator_count, word_size, word_count, length;
            |                                                          ^~~~~~
      make: *** [Makefile:304: src/ztools/showdict.o] Error 1
      make: *** Waiting for unfinished jobs....
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/home/art/src/jericho/setup.py", line 25, in <module>
          subprocess.check_call(['make', 'library', '-j', '4'], cwd=FROTZPATH)
        File "/usr/local/lib/python3.11/subprocess.py", line 413, in check_call
          raise CalledProcessError(retcode, cmd)
      subprocess.CalledProcessError: Command '['make', 'library', '-j', '4']' returned non-zero exit status 2.

I investigated updating the Frotz code in frotz but it does not appear to map exactly to any released Frotz version (closest I found was this commit) and the original commit in this jericho repo had additional files such as src/games.

[MarcCote]

Thanks for raising this issue. I was able to reproduce it on my machine. The actual error is the following.

      src/ztools/showdict.c:89:46: error: passing argument 2 of ‘decode_text_to_buffer’ from incompatible pointer type [-Wincompatible-pointer-types]
         89 |         decode_text_to_buffer(&word_address, &(dict_word->word));
            |                                              ^~~~~~~~~~~~~~~~~~
            |                                              |
            |                                              char (*)[10]

The issue is in ztools (adapted from https://github.com/ecliptik/ztools).

I have a fix for it in #79. I also fixed other errors that popped up with recent version of GCC and I will update the Github Action to run recent versions of GCC.