[moc] Add AvailabilitySet Operation for Add/Remove VM (#376)

* Make avset update operation idempotent

* Pull from master

* Updating to use platformVM and nodeagnetVM Name

* Removing platform vm Name dependency

* Remove comments

* fix

* Updating go.mod to remove moc-pkg

---------

Co-authored-by: Pradeep Kumar Gayam <[email protected]>

Author: ruinan-liu

.pipelines/build.yaml

@@ -79,7 +79,7 @@ jobs:
   steps:
   - task: GoTool@0
     inputs:
-      version: '1.22.5'
+      version: '1.24.3'
 
   - task: InstallSSHKey@0
     inputs:

Makefile

@@ -55,4 +55,4 @@ mocks:
 
 golangci-lint:
 	$(GOCMD) install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
-	$(GOPATH_BIN)/golangci-lint run --config .golangci.yml
+	$(GOPATH_BIN)/golangci-lint run --config .golangci.yml

go.sum

@@ -92,4 +92,4 @@ gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8
 gopkg.in/yaml.v2 v2.2.8 h1:obN1ZagJSUGI0Ek/LBmuj4SNLPfIny3KsKFopxRdj10=
 gopkg.in/yaml.v2 v2.2.8/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
-gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
+gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

rpc/cloudagent/compute/availabilityset/moc_cloudagent_availabilityset.proto

@@ -22,7 +22,7 @@ message AvailabilitySetResponse {
 message VirtualMachineReference {
 	string groupName = 1;
 	string name = 2;
-	string realizedName = 3;
+	string realizedName = 3; // This is nodeagnet vm name
 }
 
 message AvailabilitySetPrecheckRequest {

rpc/common/moc_common_computecommon.pb.go

@@ -258,3 +258,8 @@ message ProxyConfiguration {
 	repeated string noProxy = 3;
 	string trustedCa = 4 [(sensitivecompute) = true];
 }
+
+enum AvailabilitySetOperation {
+	ADD_VM = 0;
+	REMOVE_VM = 1;
+}

rpc/common/moc_common_computecommon.proto

@@ -7,6 +7,8 @@ package moc.nodeagent.compute;
 
 import "google/protobuf/wrappers.proto";
 import "moc_common_common.proto";
+import "moc_common_computecommon.proto";
+
 
 message AvailabilitySetRequest {
 	repeated AvailabilitySet AvailabilitySets = 1;
@@ -35,6 +37,19 @@ message AvailabilitySet {
     repeated VirtualMachineReference virtualMachines = 7;
 }
 
+message AvailabilitySetOperationRequest {
+	string AvailabilitySet = 1;
+    string NodeagentVMName = 2;
+	AvailabilitySetOperation OperationType = 3;
+}
+
+message AvailabilitySetOperationResponse {
+	google.protobuf.BoolValue Result = 2;
+	string  Error = 3;
+}
+
+
 service AvailabilitySetAgent {
 	rpc Invoke(AvailabilitySetRequest) returns (AvailabilitySetResponse) {}
+    rpc Operate(AvailabilitySetOperationRequest) returns (AvailabilitySetOperationResponse) {}
 }