-
Notifications
You must be signed in to change notification settings - Fork 14
Add MessageExtensions.AttachmentLayout type with grid support #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: heyitsaamir <[email protected]>
Co-authored-by: heyitsaamir <[email protected]>
|
@copilot remove the tests. they're not helpful. |
Co-authored-by: heyitsaamir <[email protected]>
Removed in 2a95369 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot revert this change. Then introduce a NEW type called MessagingExtensionAttachmentLayout, and use THAT for the attachmentLayout in MessagingExtensionResult. Don't forget to export types as needed in __init__s. |
…yout Co-authored-by: heyitsaamir <[email protected]>
Done in 5182bb1. Reverted Attachment.Layout to have Carousel, created new MessageExtensions.AttachmentLayout type with List and Grid, and updated Result.cs and sample code to use the new type. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
I attest that no verification is required |
|
@copilot add a README with instructions to configure the Teams Manifest to validate the MessageExtensions sample |
…tructions Co-authored-by: rido-min <[email protected]>
Added comprehensive README in 3d75a6a with:
|
|
@heyitsaamir When using Can we update the sample code to show how to use this new layout? |
@rido-min As discussed offline, the reason is that the thumbnail field is required for it ti show up in Grid mode |
Introduce a new messaging extension-specific attachment layout type with
gridsupport alongsidelist, aligning with teams.ts PR #381.Changes
MessageExtensions.AttachmentLayout: Created a new type specifically for messaging extensions withListandGridconstantsMessageExtensions.Result: Updated to use the newMessageExtensions.AttachmentLayouttype instead ofApi.Attachment.LayoutAttachment.Layout: Preserved the original type withListandCarouselconstants unchangedMessageExtensions.AttachmentLayouttypeUsage
This approach separates concerns:
Attachment.LayoutkeepsListandCarouselfor general attachmentsMessageExtensions.AttachmentLayouthasListandGridfor messaging extensionsDocumentation
The new README (
Samples/Samples.MessageExtensions/README.md) provides:> [!WARNING]
>
>
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.