-
Notifications
You must be signed in to change notification settings - Fork 6
accept dict param schema #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,11 +14,6 @@ | |
| from pydantic import BaseModel | ||
|
|
||
|
|
||
| class SearchPokemonParams(BaseModel): | ||
| pokemon_name: str | ||
| """The name of the pokemon.""" | ||
|
|
||
|
|
||
| class GetLocationParams(BaseModel): | ||
| """No parameters needed for location""" | ||
|
|
||
|
|
@@ -30,13 +25,16 @@ class GetWeatherParams(BaseModel): | |
| """The location to get weather for""" | ||
|
|
||
|
|
||
| async def pokemon_search_handler(params: SearchPokemonParams) -> str: | ||
| async def pokemon_search_handler(params: BaseModel) -> str: | ||
| """Search for Pokemon using PokeAPI - matches documentation example""" | ||
| try: | ||
| pokemon_name = getattr(params, "pokemon_name", None) | ||
| if not pokemon_name: | ||
| raise ValueError("Missing required parameter 'pokemon_name'") | ||
|
Comment on lines
+31
to
+33
|
||
| async with aiohttp.ClientSession() as session: | ||
| async with session.get(f"https://pokeapi.co/api/v2/pokemon/{params.pokemon_name.lower()}") as response: | ||
| async with session.get(f"https://pokeapi.co/api/v2/pokemon/{pokemon_name.lower()}") as response: | ||
| if response.status != 200: | ||
| raise ValueError(f"Pokemon '{params.pokemon_name}' not found") | ||
| raise ValueError(f"Pokemon '{pokemon_name}' not found") | ||
|
|
||
| data = await response.json() | ||
|
|
||
|
|
@@ -55,11 +53,16 @@ async def pokemon_search_handler(params: SearchPokemonParams) -> str: | |
| async def handle_pokemon_search(model: AIModel, ctx: ActivityContext[MessageActivity]) -> None: | ||
| """Handle single function calling - Pokemon search""" | ||
| agent = Agent(model) | ||
|
|
||
| agent.with_function( | ||
| Function( | ||
| name="pokemon_search", | ||
| description="Search for pokemon information including height, weight, and types", | ||
| parameter_schema=SearchPokemonParams, | ||
| parameter_schema={ | ||
| "type": "object", | ||
| "properties": {"pokemon_name": {"type": "string"}}, | ||
| "required": ["pokemon_name"], | ||
| }, | ||
| handler=pokemon_search_handler, | ||
| ) | ||
| ) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
type()to dynamically create classes can be hard to debug and understand. Consider usingcreate_model()from Pydantic which was already imported and provides better error handling and validation features.