-
Notifications
You must be signed in to change notification settings - Fork 36.6k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginline-completionsinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeeded
Milestone
Description
Does this issue occur when all extensions are disabled?: Yes
- VS Code Version: 1.105.1
- OS Version: MacOS 15.7.1
Steps to Reproduce:
- Open VSCode
- Make sure that you have code suggestions enabled
- Work some time normally, make sure that you see edit suggestions from time to time
- Run this line in developer console
document.querySelectorAll('[widgetid*="observablePositionWidget"]').length - Notice that every time you have an edit suggestion you have one new permanent
observalbePositionWidgetcreated which is never removed.
Problem description.
- The core problem is in this code snippet.
InlineEditsGutterIndicatoris instantiated effectively only once for each editor and then reused.- Every time
rangeis changed a new observable is created bythis._editorObs.observeLineOffsetRange - While this observables are correctly kept in this
this._storethey will be cleaned up only when editor is disposed - It means that if one works long enough and has many inline edit suggestions, they can have hundreds if not thousands of dom nodes which are effectively not used anymore.
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginline-completionsinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeeded