Query stream #407
Merged
Query stream #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reynir
reviewed
Nov 28, 2025
Member
reynir
left a comment
reynir
left a comment
There was a problem hiding this comment.
This needs to be implemented in the mirage resolver as well as it implements the same interface...
Nothing is put into the stream for now.
hannesm
force-pushed
the
query-stream
branch
from
caf439d to
d4f0084
Compare
Member
Author
|
Thanks, I made this independent of #406. Yes, there will be merge conflicts - but they will be easy to navigate :) |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Nov 30, 2025
CHANGES: * DNS: fix port encoding in HTTPS and SVCB records, add tests (mirage/ocaml-dns#399 @nickbetteridge) * Dns_resolver_root.reserved_zone_records: add private networks, extend with IPv6 networks from RFC 6303 (mirage/ocaml-dns#401 mirage/ocaml-dns#402 @hannesm) * Dns_resolver_root.reserved_zones: type is now Rr_map.t Domain_name.Map.t (mirage/ocaml-dns#402 @hannesm) * resolver: use Dns_resolver_root.reserved_zones to not lookup private zones in the authoritative nameservers (mirage/ocaml-dns#403 @hannesm) * resolver, stub: guard the usage of Dns_resolver_root.reserved_zones behind the boolean flag `add_reserved` (mirage/ocaml-dns#404 @hannesm) * stub: also record clients (if `record_clients` is provided, default is true) (mirage/ocaml-dns#405 @hannesm) * stub, resolver: add a stream (Lwt_condition.t) of query_info to display the live queries in a web interface (mirage/ocaml-dns#407 @reynir @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only last commit is relevant.This adds a stream (well, Lwt_condition.t) for queries and answers.This is currently only implemented in the stub (where we have the Lwt monad). The dns-resolver needs some functionality so the dns-resolver-mirage can adhere to the same interface.The implementation covers both stub and resolver.On top of #406;once this PR here is done and adapted to the dns-resolver, it can be used in dnsvizor for the query page.