Skip to content

Conversation

@SpaceshipCaptain
Copy link

Added all the copper chests to the chest renderer and added the "AND" condition check to support the new shelf blocks.

I also added a small bugfix to the equals method in Blockstate because it's currently deleting properties in some specific scenarios. If you add these blocks to the structure renderer in the demo you can see what I mean:

    structure.addBlock([1, 0, 0], 'minecraft:chest')
    structure.addBlock([2, 0, 0], 'minecraft:chest', { waterlogged: 'true', facing: 'north' })
    structure.addBlock([1, 1, 0], 'minecraft:chest', { waterlogged: 'false', facing: 'east' })
    structure.addBlock([2, 1, 0], 'minecraft:chest', { waterlogged: 'true', facing:'west' })
    structure.addBlock([0, 0, 0], 'minecraft:chest', { facing:'west' })
    structure.addBlock([1, 0, 1], 'minecraft:chest', { facing:'south' })

The bug makes all the chests lose their properties because the equals method is calling .every on the empty property array of the first chest and that's always going to return true. So every chest is equals to the first and they all get their properties get flattened.

I don't have a working special renderer for the copper golem statues though. I gave it a go so I'll throw that up on another branch for reference but it's a bit of a mess and might be worth nothing.

@SpaceshipCaptain
Copy link
Author

Copper golem statues branch

It's pretty rough but here is an attempt at the statues special renderer. For some reason mojang decided to define the textures of the statues with the .png inside the texture property but no other models are defined that way. I also don't know if this is a good approach for the various poses so feel free to discard any or all of this. Just thought I should at least try but I only got the standing pose fully working. The sitting pose is a start and the other poses are just empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant