mlpstorage checkpointing datasize run failed

[xin3liang]

mlpstorage checkpointing datasize run failed:

(myenv) [root@server2 storage]# mlpstorage checkpointing datasize -m llama3-8b --checkpoint-folder /root/juicefstest/mlperf-storage/mldata  -cm 64 -np 16
Traceback (most recent call last):
  File "/root/.venvs/myenv/bin/mlpstorage", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "/root/juicefstest/mlperf-storage/storage/mlpstorage/main.py", line 111, in main
    update_args(args)
  File "/root/juicefstest/mlperf-storage/storage/mlpstorage/cli.py", line 445, in update_args
    if args.mpi_params:
       ^^^^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'mpi_params'

[xutao323]

Hit same error on v2.0-branch:

(myenv) $ mlpstorage checkpointing datasize -m llama3-8b -np 8 -cm 32 -cf /mnt/storage/checkpoint_data -rd /mnt/storage/results/checkpointing --verbose
Traceback (most recent call last):
  File "/home/taoxu01/.venvs/myenv/bin/mlpstorage", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/taoxu01/storage/storage/mlpstorage/main.py", line 111, in main
    update_args(args)
  File "/home/taoxu01/storage/storage/mlpstorage/cli.py", line 445, in update_args
    if args.mpi_params:
       ^^^^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'mpi_params'

[xutao323]

According to #123 (comment), datasize doesn't need this additional mpi_params, so maybe a simple change should fix this?

--- a/mlpstorage/cli.py
+++ b/mlpstorage/cli.py
@@ -442,7 +442,7 @@ def update_args(args):
         flattened_params = [item for sublist in args.params for item in sublist]
         setattr(args, 'params', flattened_params)
 
-    if args.mpi_params:
+    if hasattr(args, 'mpi_params') and args.mpi_params:
         flattened_mpi_params = [item for sublist in args.mpi_params for item in sublist]
         setattr(args,'mpi_params', flattened_mpi_params)