Address PR comments

Author: aecsocket

apps/labrinth/src/file_hosting/mock.rs

@@ -27,7 +27,9 @@ impl FileHost for MockHost {
         file_publicity: FileHostPublicity,
         file_bytes: Bytes,
     ) -> Result<UploadFileData, FileHostingError> {
-        let path = get_file_path(file_name, file_publicity);
+        let file_name = urlencoding::decode(file_name)
+            .map_err(|_| FileHostingError::InvalidFilename)?;
+        let path = get_file_path(&file_name, file_publicity);
         std::fs::create_dir_all(
             path.parent().ok_or(FileHostingError::InvalidFilename)?,
         )?;

apps/labrinth/src/routes/internal/delphi.rs

@@ -249,18 +249,10 @@ pub async fn run(
         run_parameters.file_id.0
     );
 
-    // fix for local file paths
-    // TODO: should we fix this upstream in whatever inserts the files row?
-    let url = if file_data.url.starts_with("/") {
-        format!("file://{}", file_data.url)
-    } else {
-        file_data.url
-    };
-
     DELPHI_CLIENT
         .post(dotenvy::var("DELPHI_URL")?)
         .json(&serde_json::json!({
-            "url": url,
+            "url": file_data.url,
             "project_id": ProjectId(file_data.project_id.0 as u64),
             "version_id": VersionId(file_data.version_id.0 as u64),
             "file_id": run_parameters.file_id,

apps/labrinth/src/routes/internal/moderation/tech_review.rs

@@ -113,6 +113,8 @@ pub struct FileReport {
     pub file_name: String,
     /// Size of the flagged file, in bytes.
     pub file_size: i32,
+    /// URL to download the flagged file.
+    pub download_url: String,
     /// What issues appeared in the file.
     pub issues: Vec<FileIssue>,
 }
@@ -239,6 +241,7 @@ async fn get_report(
                 'file_name', f.filename,
                 'file_size', f.size,
                 'flag_reason', 'delphi',
+                'download_url', f.url,
                 'issues', json_array(
                     SELECT
                         to_jsonb(dri)
@@ -352,6 +355,7 @@ async fn search_projects(
                     'file_name', f.filename,
                     'file_size', f.size,
                     'flag_reason', 'delphi',
+                    'download_url', f.url,
                     'issues', json_array(
                         SELECT
                             to_jsonb(dri)