Skip to content

Commit 1af1de2

Browse files
committed
pr feedback
1 parent 978bc92 commit 1af1de2

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

test/integration/client-side-operations-timeout/client_side_operations_timeout.spec.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@ const skippedTests = {
1818
'timeoutMS is refreshed for getMore - failure':
1919
'TODO(DRIVERS-2965): see modified test in unified-csot-node-specs',
2020
'timeoutMS applies to full resume attempt in a next call': 'TODO(DRIVERS-3006)',
21-
'timeoutMS is refreshed for getMore if maxAwaitTimeMS is set': 'TODO(DRIVERS-3018)'
21+
'timeoutMS is refreshed for getMore if maxAwaitTimeMS is set': 'TODO(DRIVERS-3018)',
22+
'error on aggregate if maxAwaitTimeMS is greater than timeoutMS': 'TODO(NODE-7297)',
23+
'error on aggregate if maxAwaitTimeMS is equal to timeoutMS': 'TODO(NODE-7297)',
24+
'apply remaining timeoutMS if less than maxAwaitTimeMS': 'TODO(NODE-7297)'
2225
};
2326

2427
describe('CSOT spec tests', function () {

test/spec/client-side-operations-timeout/tailable-awaitData.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@
9898
},
9999
{
100100
"description": "error on aggregate if maxAwaitTimeMS is greater than timeoutMS",
101-
"skipReason": "NODE-7297",
102101
"operations": [
103102
{
104103
"name": "aggregate",
@@ -154,7 +153,6 @@
154153
},
155154
{
156155
"description": "error on aggregate if maxAwaitTimeMS is equal to timeoutMS",
157-
"skipReason": "NODE-7297",
158156
"operations": [
159157
{
160158
"name": "aggregate",
@@ -497,7 +495,6 @@
497495
},
498496
{
499497
"description": "apply remaining timeoutMS if less than maxAwaitTimeMS",
500-
"skipReason": "NODE-7297",
501498
"operations": [
502499
{
503500
"name": "failPoint",

test/spec/client-side-operations-timeout/tailable-awaitData.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ tests:
6262
isTimeoutError: false
6363

6464
- description: "error on aggregate if maxAwaitTimeMS is greater than timeoutMS"
65-
skipReason: NODE-7297
6665
operations:
6766
- name: aggregate
6867
object: *collection
@@ -100,7 +99,6 @@ tests:
10099
isTimeoutError: false
101100

102101
- description: "error on aggregate if maxAwaitTimeMS is equal to timeoutMS"
103-
skipReason: NODE-7297
104102
operations:
105103
- name: aggregate
106104
object: *collection
@@ -300,7 +298,6 @@ tests:
300298
collection: *collectionName
301299

302300
- description: "apply remaining timeoutMS if less than maxAwaitTimeMS"
303-
skipReason: NODE-7297
304301
operations:
305302
- name: failPoint
306303
object: testRunner

0 commit comments

Comments
 (0)