Skip to content

Commit 94c0880

Browse files
committed
test: remaining tests
1 parent 31c3c54 commit 94c0880

File tree

3 files changed

+0
-114
lines changed

3 files changed

+0
-114
lines changed

test/integration/crud/insert.test.ts

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -569,39 +569,6 @@ describe('crud - insert', function () {
569569
expect(err).to.be.instanceOf(MongoServerError);
570570
});
571571

572-
// TODO(7219): remove as it's redundant (custom ids are used in multiple other tests: "with UUID", "Date object as _id")
573-
// it('shouldCorrectlyInsertDocWithCustomId', {
574-
// // Add a tag that our runner can trigger on
575-
// // in this case we are setting that node needs to be higher than 0.10.X to run
576-
// metadata: {
577-
// requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] }
578-
// },
579-
//
580-
// test: function (done) {
581-
// const configuration = this.configuration;
582-
// const client = configuration.newClient(configuration.writeConcernMax(), { maxPoolSize: 1 });
583-
// client.connect(function (err, client) {
584-
// const db = client.db(configuration.db);
585-
// const collection = db.collection('shouldCorrectlyInsertDocWithCustomId');
586-
// // Insert the update
587-
// collection.insert(
588-
// { _id: 0, test: 'hello' },
589-
// configuration.writeConcernMax(),
590-
// function (err, result) {
591-
// expect(err).to.not.exist;
592-
// test.ok(result);
593-
//
594-
// collection.findOne({ _id: 0 }, function (err, item) {
595-
// test.equal(0, item._id);
596-
// test.equal('hello', item.test);
597-
// client.close(done);
598-
// });
599-
// }
600-
// );
601-
// });
602-
// }
603-
// });
604-
605572
it('should correctly perform upsert against new document and existing one', async function () {
606573
const configuration = this.configuration;
607574
const db = client.db(configuration.db);

test/integration/node-specific/bson-options/promote_values.test.ts

Lines changed: 0 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -31,65 +31,6 @@ describe('Promote Values', function () {
3131
await client.close();
3232
});
3333

34-
// TODO(NODE-7192): remove as it duplicates "should correctly honor promoteValues when creating an instance using Db"
35-
// it('should correctly honor promoteValues when creating an instance using MongoClient', {
36-
// // Add a tag that our runner can trigger on
37-
// // in this case we are setting that node needs to be higher than 0.10.X to run
38-
// metadata: {
39-
// requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] }
40-
// },
41-
//
42-
// test: async function () {
43-
// const configuration = this.configuration;
44-
// const client = configuration.newClient({}, { promoteValues: false });
45-
// await client.connect();
46-
// const db = client.db(configuration.db);
47-
//
48-
// await db.collection('shouldCorrectlyHonorPromoteValues').insertOne({
49-
// doc: Long.fromNumber(10),
50-
// int: 10,
51-
// double: 2.2222,
52-
// array: [[Long.fromNumber(10)]]
53-
// });
54-
//
55-
// const doc = await db.collection('shouldCorrectlyHonorPromoteValues').findOne();
56-
// expect(Long.fromNumber(10)).deep.equals(doc.doc);
57-
// expect(new Int32(10)).deep.equals(doc.int);
58-
// expect(new Double(2.2222)).deep.equals(doc.double);
59-
//
60-
// await client.close();
61-
// }
62-
// });
63-
64-
// TODO(NODE-7192): remove as it duplicates "should correctly honor promoteValues when creating an instance using Db"
65-
// it('should correctly honor promoteValues at cursor level', {
66-
// // Add a tag that our runner can trigger on
67-
// // in this case we are setting that node needs to be higher than 0.10.X to run
68-
// metadata: {
69-
// requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] }
70-
// },
71-
//
72-
// test: async function () {
73-
// const configuration = this.configuration;
74-
// const client = configuration.newClient({}, { promoteValues: false });
75-
// await client.connect();
76-
// const db = client.db(configuration.db);
77-
// await db.collection('shouldCorrectlyHonorPromoteValues').insertOne({
78-
// doc: Long.fromNumber(10),
79-
// int: 10,
80-
// double: 2.2222,
81-
// array: [[Long.fromNumber(10)]]
82-
// });
83-
//
84-
// const doc = await db.collection('shouldCorrectlyHonorPromoteValues').find().next();
85-
// expect(doc.doc).to.deep.equal(Long.fromNumber(10));
86-
// expect(doc.int).to.deep.equal(new Int32(10));
87-
// expect(doc.double).to.deep.equal(new Double(2.2222));
88-
//
89-
// await client.close();
90-
// }
91-
// });
92-
9334
it('should correctly honor promoteValues at cursor find level', async function () {
9435
const configuration = this.configuration;
9536
const client = configuration.newClient();

test/integration/node-specific/db.test.ts

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -66,28 +66,6 @@ describe('Db', function () {
6666
await client.close();
6767
});
6868

69-
// TODO(NODE-7192): remove test as it doesn't test anything
70-
// it.skip('shouldCorrectlyThrowWhenTryingToReOpenConnection', {
71-
// metadata: {
72-
// requires: { topology: ['single', 'replicaset', 'sharded'] }
73-
// },
74-
//
75-
// test: function (done) {
76-
// var configuration = this.configuration;
77-
// var client = configuration.newClient(configuration.writeConcernMax(), { maxPoolSize: 1 });
78-
// client.connect(err => {
79-
// expect(err).to.not.exist;
80-
//
81-
// try {
82-
// client.connect(function () {});
83-
// test.ok(false);
84-
// } catch {
85-
// client.close(done);
86-
// }
87-
// });
88-
// }
89-
// });
90-
9169
it('should not cut collection name when it is the same as the database', async function () {
9270
const configuration = this.configuration;
9371
const client = configuration.newClient(configuration.writeConcernMax(), { maxPoolSize: 1 });

0 commit comments

Comments
 (0)