Merge branch 'mdoc-specialchars' into v5.0-preview

Author: joelmartinez

mdoc/Mono.Documentation/monodocer.cs

@@ -2542,6 +2542,41 @@ static bool UpdateAssemblyVersionForAssemblyInfo (XmlElement e, XmlElement root,
 		"System.Runtime.CompilerServices.DynamicAttribute",
 	};
 
+	private IEnumerable<char> FilterSpecialChars (string value)
+	{
+		foreach (char c in value) {
+			switch (c) {
+				case '\0':
+					yield return '\\';
+					yield return '0';
+					break;
+				case '\t':
+					yield return '\\';
+					yield return 't';
+					break;
+				case '\n':
+					yield return '\\';
+					yield return 'n';
+					break;
+				case '\r':
+					yield return '\\';
+					yield return 'r';
+					break;
+				case '\f':
+					yield return '\\';
+					yield return 'f';
+					break;
+				case '\b':
+					yield return '\\';
+					yield return 'b';
+					break;
+				default:
+					yield return c;
+					break;
+			}
+		}
+	}
+
 	private void MakeAttributes (XmlElement root, IEnumerable<string> attributes, TypeReference t=null)
 	{
 		if (!attributes.Any ()) {
@@ -2555,11 +2590,12 @@ private void MakeAttributes (XmlElement root, IEnumerable<string> attributes, Ty
 		else if (e == null)
 			e = root.OwnerDocument.CreateElement("Attributes");
 
+
 		foreach (string attribute in attributes) {
 			XmlElement ae = root.OwnerDocument.CreateElement("Attribute");
 			e.AppendChild(ae);
-			
-			WriteElementText(ae, "AttributeName", attribute);
+			var value = new String (FilterSpecialChars (attribute).ToArray ());
+			WriteElementText(ae, "AttributeName", value);
 		}
 
 		if (e.ParentNode == null)

mdoc/Test/DocTest-InternalInterface.cs

@@ -7,6 +7,7 @@ internal interface MyInternalInterface {
 	}
 
 	public class MyClass : MyInternalInterface {
+		[System.ComponentModel.DefaultValue ('\0')]
 		public string Bar {get;set;}
 		public void BarMeth () {} // part of the interface, but publicly implemented
 

mdoc/Test/en.expected-internal-interface/MyNamespace/MyClass.xml

@@ -34,6 +34,11 @@
       <AssemblyInfo>
         <AssemblyVersion>0.0.0.0</AssemblyVersion>
       </AssemblyInfo>
+      <Attributes>
+        <Attribute>
+          <AttributeName>System.ComponentModel.DefaultValue('\0')</AttributeName>
+        </Attribute>
+      </Attributes>
       <ReturnValue>
         <ReturnType>System.String</ReturnType>
       </ReturnValue>