Remove check on the source parameter (#170)

Author: willdurand

attributioncode/sourcewhitelist.go

@@ -174,11 +174,6 @@ func (v *Validator) Validate(code, sig, refererHeader string) (*Code, error) {
 		}
 	}
 
-	if source := vals.Get("source"); !isWhitelisted(source) {
-		logEntry.WithField("source", source).Error("source is not in whitelist")
-		vals.Set("source", "(other)")
-	}
-
 	for _, val := range requiredAttributionKeys {
 		if vals.Get(val) == "" {
 			vals.Set(val, "(not set)")

attributioncode/sourcewhitelist_test.go

@@ -168,12 +168,6 @@ func TestRedirectFull(t *testing.T) {
 			ExpectedLocation: `/cdn/builds/firefox-stub/en-US/win/`,
 			ExpectedCode:     `campaign%3D%2528not%2Bset%2529%26content%3D%2528not%2Bset%2529%26dltoken%3D[\w\d-]+%26medium%3Dorganic%26source%3Dwww.google.com`,
 		},
-		{
-			AttributionCode:  `campaign=%28not+set%29&content=%28not+set%29&medium=organic&source=www.notinwhitelist.com`,
-			Referer:          "",
-			ExpectedLocation: `/cdn/builds/firefox-stub/en-US/win/`,
-			ExpectedCode:     `campaign%3D%2528not%2Bset%2529%26content%3D%2528not%2Bset%2529%26dltoken%3D[\w\d-]+%26medium%3Dorganic%26source%3D%2528other%2529`,
-		},
 		{
 			// We expect the product to be prefixed in the location URL below because
 			// the attribution code contains data for RTAMO and the referer header
@@ -344,10 +338,6 @@ func TestDirectFull(t *testing.T) {
 			AttributionCode: `campaign=%28not+set%29&content=%28not+set%29&medium=organic&source=www.google.com`,
 			ExpectedCode:    `campaign%3D%2528not%2Bset%2529%26content%3D%2528not%2Bset%2529%26dltoken%3D[\w\d-]+%26medium%3Dorganic%26source%3Dwww.google.com`,
 		},
-		{
-			AttributionCode: `campaign=%28not+set%29&content=%28not+set%29&medium=organic&source=notinthewhitelist.com`,
-			ExpectedCode:    `campaign%3D%2528not%2Bset%2529%26content%3D%2528not%2Bset%2529%26dltoken%3D[\w\d-]+%26medium%3Dorganic%26source%3D%2528other%2529`,
-		},
 	} {
 		testHook.Reset()