intermittent failure view fixes

Author: camd

comparison-tools/config_comparator.py

@@ -154,14 +154,14 @@ def get_local_environment_config(self) -> dict[str, Any]:
             result = subprocess.run(["python", "--version"], capture_output=True, text=True)
             if result.returncode == 0:
                 config["python_version"] = result.stdout.strip()
-        except:
+        except Exception:
             pass
 
         try:
             result = subprocess.run(["node", "--version"], capture_output=True, text=True)
             if result.returncode == 0:
                 config["node_version"] = result.stdout.strip()
-        except:
+        except Exception:
             pass
 
         return config
@@ -421,7 +421,7 @@ def main():
 
     try:
         comparison = comparator.run_comparison()
-        report = comparator.generate_report(comparison, args.output)
+        _report = comparator.generate_report(comparison, args.output)
 
         # Exit with error code if there are significant differences
         significant_diffs = [

comparison-tools/db_comparator.py

@@ -85,8 +85,8 @@ def get_database_info(self, conn: psycopg2.extensions.connection) -> dict[str, A
 
             # Get table count
             cursor.execute("""
-                SELECT COUNT(*) as table_count 
-                FROM information_schema.tables 
+                SELECT COUNT(*) as table_count
+                FROM information_schema.tables
                 WHERE table_schema = 'public';
             """)
             table_count = cursor.fetchone()["table_count"]
@@ -117,8 +117,8 @@ def get_table_info(
                 cursor.execute(
                     """
                     SELECT EXISTS (
-                        SELECT FROM information_schema.tables 
-                        WHERE table_schema = 'public' 
+                        SELECT FROM information_schema.tables
+                        WHERE table_schema = 'public'
                         AND table_name = %s
                     );
                 """,
@@ -131,14 +131,14 @@ def get_table_info(
                 # Get column information
                 cursor.execute(
                     """
-                    SELECT 
+                    SELECT
                         column_name,
                         data_type,
                         is_nullable,
                         column_default,
                         character_maximum_length
                     FROM information_schema.columns
-                    WHERE table_schema = 'public' 
+                    WHERE table_schema = 'public'
                     AND table_name = %s
                     ORDER BY ordinal_position;
                 """,
@@ -432,7 +432,7 @@ def main():
 
     try:
         comparison = comparator.run_comparison()
-        report = comparator.generate_report(comparison, args.output)
+        _report = comparator.generate_report(comparison, args.output)
 
         # Exit with error code if there are significant differences
         has_issues = (

comparison-tools/run_comparison.py

@@ -336,7 +336,7 @@ def generate_html_report(self, master_report):
         <h1>Treeherder Master Comparison Report</h1>
         <p>Generated: {master_report["comparison_summary"]["timestamp"]}</p>
     </div>
-    
+
     <div class="summary">
         <h2>Summary</h2>
         <p><strong>Local URL:</strong> {master_report["comparison_summary"]["local_base_url"]}</p>
@@ -346,15 +346,15 @@ def generate_html_report(self, master_report):
         <p><strong>Failed:</strong> {master_report["comparison_summary"]["failed_tools"]}</p>
         <p><strong>Success Rate:</strong> {master_report["comparison_summary"]["success_rate"]:.1f}%</p>
     </div>
-    
+
     <div class="recommendations">
         <h2>Recommendations</h2>
         {self.format_recommendations_html(master_report["recommendations"])}
     </div>
-    
+
     <h2>Tool Results</h2>
     {self.format_tool_results_html(master_report["tool_results"])}
-    
+
 </body>
 </html>"""
 
@@ -379,11 +379,11 @@ def format_tool_results_html(self, results):
             html += f"""
             <div class="tool-result {success_class}">
                 <h3>{result["tool"].replace("_", " ").title()} - {status}</h3>
-                
+
                 {f"<p><strong>Report File:</strong> {result['report_file']}</p>" if result.get("report_file") else ""}
-                
+
                 {f"<h4>Output:</h4><pre>{result['output']}</pre>" if result.get("output") else ""}
-                
+
                 {f"<h4>Error:</h4><pre>{result['error']}</pre>" if result.get("error") else ""}
             </div>
             """

ui/css/intermittent-failures.css

@@ -61,6 +61,23 @@ ul {
 }
 
 /* ReactTable style */
+.ReactTable .rt-thead .rt-tr,
+.ReactTable .rt-tbody .rt-tr,
+.ReactTable .rt-td,
+.ReactTable .rt-th {
+  text-align: left;
+}
+
+/* Keep pagination controls on one row */
+.ReactTable .-pagination {
+  flex-wrap: nowrap;
+}
+
+.ReactTable .-pagination .-center {
+  flex-wrap: nowrap;
+  white-space: nowrap;
+}
+
 .ReactTable .-pagination .-btn:focus {
   box-shadow: 0 0 0 0.2rem rgba(130, 138, 145, 0.5);
 }

ui/css/perf.css

@@ -799,3 +799,15 @@ li.pagination-active.active > button {
   font-size: 14px !important;
   color: white !important;
 }
+
+/* Consistent checkbox sizing for alerts table */
+.compare-table .form-check-input {
+  width: 1.25em;
+  height: 1.25em;
+  margin-top: 0.125em;
+  cursor: pointer;
+}
+
+.compare-table .form-check-input:disabled {
+  cursor: not-allowed;
+}

ui/css/treeherder-custom-styles.css

@@ -10,6 +10,25 @@
  * when adding new styles.
  */
 
+/* Set base font size to match pre-Bootstrap 5 styling */
+html {
+  font-size: 14px;
+}
+
+/* Ensure Bootstrap components inherit the base font size */
+.btn:not(.job-btn):not(.runnable-job-btn):not(.btn-push):not(.btn-view-nav):not(.btn-view-nav-closed):not(.group-btn):not(.group-symbol):not(.group-select-all-runnable),
+.dropdown-toggle,
+.dropdown-item,
+.dropdown-menu,
+.form-control,
+.form-select,
+.input-group-text,
+.alert,
+.nav-link,
+a {
+  font-size: 1rem;
+}
+
 /* Bootstrap 4 will not show <a> as a link style if it has no href.
    This adds that style back. */
 .link-style {
@@ -315,6 +334,12 @@
   color: #0d7d8f;
 }
 
+.alert-info {
+  color: #0c5460;
+  background-color: #d1ecf1;
+  border-color: #bee5eb;
+}
+
 .alert-darker-info,
 .badge-darker-info {
   background: #0d7d8f;

ui/css/treeherder-navbar.css

@@ -73,14 +73,14 @@ label.dropdown-item.active,
 
 .navbar-right {
   display: flex;
-  justify-content: flex-end;
+  align-items: center;
 }
 
 .nav-menu-btn {
   margin-right: -4px;
   padding-left: 14px;
   padding-right: 14px;
-  font-size: 13px;
+  font-size: 14px;
 }
 
 .nav-menu-btn.dropdown-toggle {
@@ -127,6 +127,7 @@ secondary-nav-bar {
   width: 100%;
   display: flex;
   background-color: #354048;
+  min-height: 33px;
 }
 
 .tree-closed {
@@ -257,7 +258,8 @@ secondary-nav-bar {
 
 .btn-unclassified-failures {
   margin-top: 1px;
-  padding: 3px 10px;
+  padding: 2px 8px;
+  font-size: 13px;
   background-color: rgba(78, 93, 21, 0.56);
   border-color: #9fa01d;
   color: lightgray;
@@ -303,13 +305,14 @@ fieldset[disabled] .btn-unclassified-failures.active {
   border-bottom: 0;
   border-top: 0;
   border-right: 0;
+  font-size: 0.875rem;
 }
 
 .btn-view-nav:hover,
 .btn-view-nav:focus,
 .btn-view-nav:active,
 .btn-view-nav.active {
-  background-color: #2c3133 !important;
+  background-color: #404446 !important;
   border-color: #1a1d20 !important;
   color: white;
 }
@@ -478,3 +481,8 @@ fieldset[disabled] .btn-view-nav-closed.active {
 .btn-watched-repo {
   padding: 0.375rem 0.5rem;
 }
+
+/* Remove caret from repository dropdown toggle */
+.no-caret::after {
+  display: none !important;
+}

ui/css/treeherder-pushes.css

@@ -4,7 +4,7 @@
 
 .push-bar {
   border-top: 1px solid black;
-  padding: 2px 0 1px 34px;
+  padding: 2px 0 1px 12px;
   white-space: nowrap;
   display: flex;
   flex-flow: row nowrap;
@@ -72,6 +72,7 @@
   padding-left: 9px;
   padding-right: 10px;
   border: 0;
+  font-size: 12px;
 }
 
 .btn-push:hover {
@@ -154,6 +155,7 @@ fieldset[disabled] .btn-push:hover {
   min-width: 14.5em;
   overflow: hidden;
   vertical-align: top;
+  text-align: left;
 }
 
 .job-row {
@@ -162,6 +164,7 @@ fieldset[disabled] .btn-push:hover {
   white-space: normal;
   word-break: normal;
   padding-top: 0;
+  text-align: left;
   padding-bottom: 0;
 }
 

ui/intermittent-failures/DateOptions.jsx

@@ -47,7 +47,7 @@ export default class DateOptions extends React.Component {
 
     return (
       <div className="d-inline-block">
-        <DropdownButton className="mr-3" title="date range">
+        <DropdownButton className="me-3" title="date range">
           <DropdownMenuItems
             options={dateOptions}
             updateData={this.updateDateRange}

ui/intermittent-failures/DateRangePicker.jsx

@@ -91,7 +91,7 @@ export default class DateRangePicker extends React.Component {
           isOutsideRange={(day) => moment().diff(day) < 0}
           phrases={defaultPhrases}
         />
-        <Button variant="secondary" className="ml-3" onClick={this.updateData}>
+        <Button variant="secondary" className="ms-3" onClick={this.updateData}>
           update
         </Button>
       </div>