Skip to content

Commit ae92fcd

Browse files
feat: hw2-493 - Reverting custom account fields
1 parent e52d7ca commit ae92fcd

File tree

6 files changed

+46
-114
lines changed

6 files changed

+46
-114
lines changed

mdx-models/src/main/java/com/mx/path/model/mdx/model/account/Account.java

Lines changed: 0 additions & 90 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ public class Account extends MdxBase<Account> {
3131
private BigDecimal creditLimit;
3232
@XmlElement(name = "currency_code")
3333
private String currencyCode;
34-
@XmlElement(name = "daily_deposit_limit_current")
35-
private Double dailyDepositLimitCurrent;
36-
@XmlElement(name = "daily_deposit_limit_total")
37-
private Double dailyDepositLimitTotal;
3834
@XmlElement(name = "day_payment_is_due")
3935
private LocalDate dayPaymentIsDue;
4036
@XmlElement(name = "guid")
@@ -45,10 +41,6 @@ public class Account extends MdxBase<Account> {
4541
private BigDecimal holdTotal;
4642
@XmlElement(name = "id")
4743
private String id;
48-
@XmlElement(name = "interest_paid_previous_year")
49-
private Double interestPaidPreviousYear;
50-
@XmlElement(name = "interest_paid_ytd")
51-
private Double interestPaidYtd;
5244
@XmlElement(name = "interest_rate")
5345
private Double interestRate;
5446
@XmlElement(name = "is_closed")
@@ -61,10 +53,6 @@ public class Account extends MdxBase<Account> {
6153
private Long lastPaymentAt;
6254
@XmlElement(name = "last_payment_on")
6355
private LocalDate lastPaymentOn;
64-
@XmlElement(name = "monthly_deposit_limit_current")
65-
private Double monthlyDepositLimitCurrent;
66-
@XmlElement(name = "monthly_deposit_limit_total")
67-
private Double monthlyDepositLimitTotal;
6856
@XmlElement(name = "matures_at")
6957
private Long maturesAt;
7058
@XmlElement(name = "matures_on")
@@ -85,8 +73,6 @@ public class Account extends MdxBase<Account> {
8573
private String name;
8674
@XmlElement(name = "nickname")
8775
private String nickname;
88-
@XmlElement(name = "next_payment")
89-
private Double nextPayment;
9076
@XmlElement(name = "original_balance")
9177
private BigDecimal originalBalance;
9278
@XmlElement(name = "past_due_amount")
@@ -103,8 +89,6 @@ public class Account extends MdxBase<Account> {
10389
private BigDecimal pendingBalance;
10490
@XmlElement(name = "pending_transactions_total")
10591
private BigDecimal pendingTransactionsTotal;
106-
@XmlElement(name = "principal_balance")
107-
private Double principalBalance;
10892
@XmlElement(name = "routing_number")
10993
private String routingNumber;
11094
@Deprecated
@@ -118,8 +102,6 @@ public class Account extends MdxBase<Account> {
118102
private BigDecimal statementBalance;
119103
@XmlElement(name = "statement_closed_on")
120104
private LocalDate statementClosedOn;
121-
@XmlElement(name = "statement_late_charges")
122-
private Double statementLateCharges;
123105
@XmlElement(name = "subtype")
124106
private String subtype;
125107
@XmlElement(name = "type")
@@ -227,22 +209,6 @@ public final void setCurrencyCode(String newCurrencyCode) {
227209
this.currencyCode = newCurrencyCode;
228210
}
229211

230-
public final Double getDailyDepositLimitCurrent() {
231-
return dailyDepositLimitCurrent;
232-
}
233-
234-
public final void setDailyDepositLimitCurrent(Double dailyDepositLimitCurrent) {
235-
this.dailyDepositLimitCurrent = dailyDepositLimitCurrent;
236-
}
237-
238-
public final Double getDailyDepositLimitTotal() {
239-
return dailyDepositLimitTotal;
240-
}
241-
242-
public final void setDailyDepositLimitTotal(Double dailyDepositLimitTotal) {
243-
this.dailyDepositLimitTotal = dailyDepositLimitTotal;
244-
}
245-
246212
public final LocalDate getDayPaymentIsDue() {
247213
return dayPaymentIsDue;
248214
}
@@ -283,22 +249,6 @@ public final void setId(String newId) {
283249
this.id = newId;
284250
}
285251

286-
public final Double getInterestPaidPreviousYear() {
287-
return interestPaidPreviousYear;
288-
}
289-
290-
public final void setInterestPaidPreviousYear(Double interestPaidPreviousYear) {
291-
this.interestPaidPreviousYear = interestPaidPreviousYear;
292-
}
293-
294-
public final Double getInterestPaidYtd() {
295-
return interestPaidYtd;
296-
}
297-
298-
public final void setInterestPaidYtd(Double interestPaidYtd) {
299-
this.interestPaidYtd = interestPaidYtd;
300-
}
301-
302252
public final Double getInterestRate() {
303253
return interestRate;
304254
}
@@ -347,22 +297,6 @@ public final void setLastPaymentOn(LocalDate newLastPaymentOn) {
347297
this.lastPaymentOn = newLastPaymentOn;
348298
}
349299

350-
public final Double getMonthlyDepositLimitCurrent() {
351-
return monthlyDepositLimitCurrent;
352-
}
353-
354-
public final void setMonthlyDepositLimitCurrent(Double monthlyDepositLimitCurrent) {
355-
this.monthlyDepositLimitCurrent = monthlyDepositLimitCurrent;
356-
}
357-
358-
public final Double getMonthlyDepositLimitTotal() {
359-
return monthlyDepositLimitTotal;
360-
}
361-
362-
public final void setMonthlyDepositLimitTotal(Double monthlyDepositLimitTotal) {
363-
this.monthlyDepositLimitTotal = monthlyDepositLimitTotal;
364-
}
365-
366300
public final Long getMaturesAt() {
367301
return maturesAt;
368302
}
@@ -443,14 +377,6 @@ public final void setNickname(String newNickname) {
443377
this.nickname = newNickname;
444378
}
445379

446-
public final Double getNextPayment() {
447-
return nextPayment;
448-
}
449-
450-
public final void setNextPayment(Double nextPayment) {
451-
this.nextPayment = nextPayment;
452-
}
453-
454380
public final BigDecimal getOriginalBalance() {
455381
return originalBalance;
456382
}
@@ -515,14 +441,6 @@ public final void setPendingTransactionsTotal(BigDecimal pendingTransactionsTota
515441
this.pendingTransactionsTotal = pendingTransactionsTotal;
516442
}
517443

518-
public final Double getPrincipalBalance() {
519-
return principalBalance;
520-
}
521-
522-
public final void setPrincipalBalance(Double principalBalance) {
523-
this.principalBalance = principalBalance;
524-
}
525-
526444
public final String getRoutingNumber() {
527445
return routingNumber;
528446
}
@@ -571,14 +489,6 @@ public final void setStatementClosedOn(LocalDate newStatementClosedOn) {
571489
this.statementClosedOn = newStatementClosedOn;
572490
}
573491

574-
public final Double getStatementLateCharges() {
575-
return statementLateCharges;
576-
}
577-
578-
public final void setStatementLateCharges(Double statementLateCharges) {
579-
this.statementLateCharges = statementLateCharges;
580-
}
581-
582492
public final String getSubtype() {
583493
return subtype;
584494
}

mdx-models/src/main/java/com/mx/path/model/mdx/model/account/StopPayment.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.mx.path.model.mdx.model.account;
22

3-
import java.time.LocalDate;
4-
53
import lombok.Data;
64
import lombok.EqualsAndHashCode;
75

@@ -11,7 +9,6 @@
119
@Data
1210
public class StopPayment extends MdxBase<StopPayment> {
1311
private Double amount;
14-
private LocalDate effectiveOn;
1512
private String endingCheckNumber;
1613
private Double fee;
1714
private String id;

mdx-models/src/main/java/com/mx/path/model/mdx/model/account/Transaction.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.mx.path.model.mdx.model.account;
22

3-
import java.math.BigDecimal;
43
import java.time.LocalDate;
54

65
import javax.xml.bind.annotation.XmlElement;
@@ -54,8 +53,6 @@ public class Transaction extends MdxBase<Transaction> {
5453
private Long postedAt;
5554
@XmlElement(name = "posted_on")
5655
private LocalDate postedOn;
57-
@XmlElement(name = "running_balance")
58-
private BigDecimal runningBalance;
5956
@XmlElement(name = "status")
6057
private String status;
6158
@XmlElement(name = "transacted_at")
@@ -235,14 +232,6 @@ public final void setPostedOn(LocalDate newPostedOn) {
235232
this.postedOn = newPostedOn;
236233
}
237234

238-
public final BigDecimal getRunningBalance() {
239-
return runningBalance;
240-
}
241-
242-
public final void setRunningBalance(BigDecimal runningBalance) {
243-
this.runningBalance = runningBalance;
244-
}
245-
246235
public final String getStatus() {
247236
return status;
248237
}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package com.mx.path.extensions
2+
3+
class StringStaticExtension {
4+
5+
static String sanitizeXml(final StringWriter self) {
6+
sanitizeXml(self.toString())
7+
}
8+
9+
static String sanitizeXml(final String self) {
10+
self.replaceAll("\n","").replaceAll("\r","").replaceAll("\t","").replaceAll(">\\s+<", "")
11+
}
12+
}

mdx-models/src/test/groovy/com/mx/path/model/mdx/model/ondemand/MdxOnDemandMdxListSerializerTest.groovy

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.mx.path.model.mdx.model.ondemand
22

3+
import static com.mx.path.extensions.StringStaticExtension.sanitizeXml
4+
35
import com.fasterxml.jackson.core.JsonGenerator
46
import com.fasterxml.jackson.databind.SerializerProvider
57
import com.fasterxml.jackson.dataformat.xml.XmlFactory
@@ -52,12 +54,14 @@ class MdxOnDemandMdxListSerializerTest extends Specification implements WithMock
5254
generator.flush()
5355

5456
then:
55-
stringWriter.toString() == "<Transaction>\n" +
57+
def expectedResponse = "<Transaction>\n" +
5658
" <wrapped>false</wrapped>\n" +
5759
" <amount>9.99</amount>\n" +
5860
" <description>Fees</description>\n" +
5961
" <id>T-123</id>\n" +
6062
"</Transaction>\n"
63+
64+
sanitizeXml(stringWriter) == sanitizeXml(expectedResponse)
6165
}
6266

6367
def "wrapper name, empty interacts with generator"() {
@@ -108,7 +112,7 @@ class MdxOnDemandMdxListSerializerTest extends Specification implements WithMock
108112
generator.flush()
109113

110114
then:
111-
stringWriter.toString() == "<mdx version=\"5.0\">\n" +
115+
def expectedResponse = "<mdx version=\"5.0\">\n" +
112116
"<transactions>\n" +
113117
"<Transaction>\n" +
114118
" <wrapped>false</wrapped>\n" +
@@ -124,6 +128,8 @@ class MdxOnDemandMdxListSerializerTest extends Specification implements WithMock
124128
"</Transaction>\n" +
125129
"</transactions>\n" +
126130
"</mdx>\n"
131+
132+
sanitizeXml(stringWriter) == sanitizeXml(expectedResponse)
127133
}
128134

129135
def "wraps list interacts with generator applies mixins"() {
@@ -149,7 +155,7 @@ class MdxOnDemandMdxListSerializerTest extends Specification implements WithMock
149155
subject.serialize(list, (JsonGenerator) generator, (SerializerProvider) null)
150156

151157
then:
152-
stringWriter.toString() == "<mdx version=\"5.0\">\n" +
158+
def expectedResponse = "<mdx version=\"5.0\">\n" +
153159
"<accounts>\n" +
154160
"<account>\n" +
155161
" <balance>9.99</balance>\n" +
@@ -161,5 +167,7 @@ class MdxOnDemandMdxListSerializerTest extends Specification implements WithMock
161167
"</account>\n"
162168
"</accounts>\n" +
163169
"</mdx>\n"
170+
171+
sanitizeXml(stringWriter) == sanitizeXml(expectedResponse)
164172
}
165173
}

0 commit comments

Comments
 (0)