Skip to content

Commit fc34ee5

Browse files
committed
Improve JEP 378 text block support
MyBatipse now requires Eclipse 2020-06 or later.
1 parent 5265076 commit fc34ee5

File tree

10 files changed

+17
-9
lines changed

10 files changed

+17
-9
lines changed

mybatipse/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Require-Bundle: org.eclipse.core.runtime,
1414
org.eclipse.ui,
1515
org.eclipse.ui.ide,
1616
org.eclipse.core.resources,
17-
org.eclipse.jdt.core;bundle-version="3.10.0",
17+
org.eclipse.jdt.core;bundle-version="3.24.0",
1818
org.eclipse.jdt.ui,
1919
org.eclipse.ui.workbench.texteditor,
2020
org.eclipse.wst.validation,

mybatipse/plugin.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,9 @@
434434
<partition
435435
type="__java_string">
436436
</partition>
437+
<partition
438+
type="__java_multiline_string">
439+
</partition>
437440
</javaCompletionProposalComputer>
438441
</extension>
439442
<extension

mybatipse/src/net/harawata/mybatipse/bean/BeanPropertyCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ protected static void parseSource(IJavaProject project, final IType type,
335335
{
336336
ICompilationUnit compilationUnit = (ICompilationUnit)type
337337
.getAncestor(IJavaElement.COMPILATION_UNIT);
338-
ASTParser parser = ASTParser.newParser(AST.JLS8);
338+
ASTParser parser = ASTParser.newParser(AST.JLS15);
339339
parser.setKind(ASTParser.K_COMPILATION_UNIT);
340340
parser.setSource(compilationUnit);
341341
parser.setResolveBindings(true);

mybatipse/src/net/harawata/mybatipse/cache/JavaMapperCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ private static void parseSourceMapper(final IJavaProject project, final IType ma
203203
{
204204
ICompilationUnit compilationUnit = (ICompilationUnit)mapperType
205205
.getAncestor(IJavaElement.COMPILATION_UNIT);
206-
ASTParser parser = ASTParser.newParser(AST.JLS8);
206+
ASTParser parser = ASTParser.newParser(AST.JLS15);
207207
parser.setKind(ASTParser.K_COMPILATION_UNIT);
208208
parser.setSource(compilationUnit);
209209
parser.setResolveBindings(true);

mybatipse/src/net/harawata/mybatipse/hyperlink/JavaHyperlinkDetector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public IHyperlink[] detectHyperlinks(ITextViewer textViewer, IRegion region,
107107
else if (srcElements.length == 0)
108108
{
109109
// Annotation value?
110-
final ASTParser parser = ASTParser.newParser(AST.JLS8);
110+
final ASTParser parser = ASTParser.newParser(AST.JLS15);
111111
parser.setKind(ASTParser.K_COMPILATION_UNIT);
112112
parser.setSource(typeRoot);
113113
parser.setResolveBindings(true);

mybatipse/src/net/harawata/mybatipse/mybatis/JavaMapperUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ private static void findMapperMethodSource(MapperMethodStore methodStore,
130130
{
131131
ICompilationUnit compilationUnit = (ICompilationUnit)mapperType
132132
.getAncestor(IJavaElement.COMPILATION_UNIT);
133-
ASTParser parser = ASTParser.newParser(AST.JLS8);
133+
ASTParser parser = ASTParser.newParser(AST.JLS15);
134134
parser.setKind(ASTParser.K_COMPILATION_UNIT);
135135
parser.setSource(compilationUnit);
136136
parser.setResolveBindings(true);

mybatipse/src/net/harawata/mybatipse/mybatis/TypeAliasCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ private void scanJavaConfig(IJavaProject project, final TypeAliasMap aliasMap,
344344

345345
for (ITypeRoot typeRoot : typeRoots)
346346
{
347-
ASTParser parser = ASTParser.newParser(AST.JLS8);
347+
ASTParser parser = ASTParser.newParser(AST.JLS15);
348348
parser.setSource(typeRoot);
349349
parser.setResolveBindings(true);
350350
CompilationUnit astUnit = (CompilationUnit)parser.createAST(null);

mybatipse/src/net/harawata/mybatipse/quickassist/JavaQuickAssistProcessor.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
import org.eclipse.jdt.core.dom.SimpleName;
4949
import org.eclipse.jdt.core.dom.SingleMemberAnnotation;
5050
import org.eclipse.jdt.core.dom.StringLiteral;
51+
import org.eclipse.jdt.core.dom.TextBlock;
5152
import org.eclipse.jdt.core.dom.Type;
5253
import org.eclipse.jdt.core.dom.TypeDeclaration;
5354
import org.eclipse.jdt.core.dom.TypeLiteral;
@@ -165,7 +166,7 @@ public void apply(IDocument document)
165166

166167
private CompilationUnit getAstNode(ICompilationUnit compilationUnit)
167168
{
168-
ASTParser parser = ASTParser.newParser(AST.JLS8);
169+
ASTParser parser = ASTParser.newParser(AST.JLS15);
169170
parser.setSource(compilationUnit);
170171
parser.setKind(ASTParser.K_COMPILATION_UNIT);
171172
parser.setResolveBindings(true);
@@ -383,6 +384,10 @@ private String parseStringValue(Expression value, String separator)
383384
{
384385
return ((StringLiteral)value).getLiteralValue();
385386
}
387+
else if (valueType == ASTNode.TEXT_BLOCK)
388+
{
389+
return ((TextBlock)value).getLiteralValue();
390+
}
386391
else if (valueType == ASTNode.ARRAY_INITIALIZER)
387392
{
388393
StringBuilder buffer = new StringBuilder();

mybatipse/src/net/harawata/mybatipse/refactoring/collector/ResultMapRenameEditCollector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ private void editJavaSource(RefactoringStatus result) throws JavaModelException
171171
if (compilationUnit == null)
172172
return;
173173

174-
final ASTParser parser = ASTParser.newParser(AST.JLS8);
174+
final ASTParser parser = ASTParser.newParser(AST.JLS15);
175175
parser.setKind(ASTParser.K_COMPILATION_UNIT);
176176
parser.setSource(compilationUnit);
177177
parser.setResolveBindings(true);

mybatipse/src/net/harawata/mybatipse/refactoring/handler/JavaElementRenameHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public Object execute(ExecutionEvent event) throws ExecutionException
6969
final ITextEditor textEditor = editor.getAdapter(ITextEditor.class);
7070
final int offset = ((ITextSelection)textEditor.getSelectionProvider().getSelection())
7171
.getOffset();
72-
final ASTParser parser = ASTParser.newParser(AST.JLS8);
72+
final ASTParser parser = ASTParser.newParser(AST.JLS15);
7373
parser.setKind(ASTParser.K_COMPILATION_UNIT);
7474
parser.setSource(compilationUnit);
7575
parser.setResolveBindings(true);

0 commit comments

Comments
 (0)