Add get_account_fees() #173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mkazlauskas thanks for the PR. I will review it ASAP |
Contributor
|
As a first though: Nash should also be supported. I will check how to do it. |
notdanilo
added
Priority: Regular
Type: Enhancement
Contributor
|
nash-rust needs to implement getAccountVolumes, see nash-io/nash-rust#62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#172
Implemented for Binance and Coinbase. Didn't find Nash API docs, so for now it will return a not implemented error. I can implement it for Nash if anyone post a link to relevant docs.
I tested this in my personal project for both exchanges (not via
cargo test). Not sure how to set up the tests - a lot of tests (including the new tests) failed after adding.envfile with my sandbox credentials for Binance.I'm new to both rust and this project. I'll happily make an required changes.
Note: there are 2 unrelated changes in binance account tests:
let get_price_ticker_request = GetPriceTickerRequest {- it is the only place, so it doesn't seem like my editor config is different than what you guys are using - it may actually be a good change..expect("Couldn't get acount balances.");