FileConventions(Test),scripts: acknowledge .env

Take .env file into account in
inconsistentVersionsInGitHubCI.fsx script when searching for
vars referenced in Github workflow files, when .env file is
present in the repository root. This is needed because
workflows in pulumi-deploy now load vars from .env file.

Author: webwarrior-ws

scripts/inconsistentVersionsInGitHubCI.fsx

@@ -33,6 +33,29 @@ let targetDir =
         |> fst
 
 let inconsistentVersionsInGitHubCI =
+    let repositoryRootDir = targetDir.Parent.Parent
+
+    let globalEnv =
+        let dotEnvFile =
+            Path.Join(repositoryRootDir.FullName, ".env") |> FileInfo
+
+        if dotEnvFile.Exists then
+            let lines = File.ReadAllLines dotEnvFile.FullName
+
+            lines
+            |> Seq.filter(fun line ->
+                not(
+                    System.String.IsNullOrWhiteSpace line || line.StartsWith '#'
+                )
+            )
+            |> Seq.map(fun line ->
+                let [| key; value |] = line.Split('=', count = 2)
+                key.Trim(), value.Trim()
+            )
+            |> Map.ofSeq
+        else
+            Map.empty
+
     FileConventions.DetectInconsistentVersionsInGitHubCI targetDir globalEnv
 
 if inconsistentVersionsInGitHubCI then

src/FileConventions/Library.fs

@@ -362,7 +362,7 @@ let private GetVersionsMapFromFiles
 let private DetectInconsistentVersionsInYamlFiles
     (fileInfos: seq<FileInfo>)
     (extractVersionsFunction: YamlNode -> seq<string * string>)
-    (_globalEnv: Map<string, string>)
+    (globalEnv: Map<string, string>)
     =
     let envVarRegex =
         Regex(@"\s*\$\{\{\s*([^\s\}]+)\s*\}\}\s*", RegexOptions.Compiled)
@@ -383,33 +383,44 @@ let private DetectInconsistentVersionsInYamlFiles
                 let matches =
                     Seq.collect extractVersionsFunction yamlDoc.AllNodes
 
+                let yamlDict = yamlDoc :?> YamlMappingNode
+
+                let localEnv =
+                    match yamlDict.Children.TryGetValue "env" with
+                    | true, (:? YamlMappingNode as node) -> node
+                    | _ -> YamlMappingNode()
+
+                let envDict =
+                    localEnv.Children
+                    |> Seq.fold
+                        (fun acc pair ->
+                            acc
+                            |> Map.add
+                                (pair.Key :?> YamlScalarNode).Value
+                                (pair.Value :?> YamlScalarNode).Value
+                        )
+                        globalEnv
+
                 matches
                 |> Seq.fold
                     (fun acc (key, value) ->
                         let actualValue =
                             let variableRegexMatch = envVarRegex.Match value
 
                             if variableRegexMatch.Success then
-                                let yamlDict = yamlDoc :?> YamlMappingNode
-
-                                match yamlDict.Children.TryGetValue "env" with
-                                | true, (:? YamlMappingNode as envDict) ->
-                                    let referenceString =
-                                        variableRegexMatch.Groups.[1].Value
-
-                                    let envVarName =
-                                        if referenceString.StartsWith "env." then
-                                            referenceString.[4..]
-                                        else
-                                            referenceString
-
-                                    match
-                                        envDict.Children.TryGetValue envVarName
-                                        with
-                                    | true, envVarValue ->
-                                        (envVarValue :?> YamlScalarNode).Value
-                                    | false, _ -> value
-                                | _ -> value
+                                let referenceString =
+                                    variableRegexMatch.Groups.[1].Value
+
+                                let envVarName =
+                                    if referenceString.StartsWith "env." then
+                                        referenceString.[4..]
+                                    else
+                                        referenceString
+
+                                match envDict.TryGetValue envVarName with
+                                | true, envVarValue -> envVarValue
+                                | false, _ ->
+                                    failwithf "env. var %s not found" envVarName
                             else
                                 value